specialize show of : to make reshape trimmable
#59598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
trimming
topolarity
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
I expect lots of users will still hit this for string(...) of a user-defined structs etc., so I was kind of hoping we'd define a decent --trim fallback for show_default, e.g. w/ @generated to iterate struct fields type-stably.
Anyway, this is enough for reshape(...) so definitely worth taking as-is.
Thanks!
This was referenced Sep 24, 2025
Merged
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
I also noticed that the standard Base.show_type_name appears to be trimmable so we don't need the override. We might still want it for code size, but probably not a big deal.
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2025
I also noticed that the standard Base.show_type_name appears to be trimmable so we don't need the override. We might still want it for code size, but probably not a big deal. (cherry picked from commit 12f7bb5)
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
I also noticed that the standard Base.show_type_name appears to be trimmable so we don't need the override. We might still want it for code size, but probably not a big deal. (cherry picked from commit 12f7bb5)
KristofferC
pushed a commit
that referenced
this pull request
Oct 14, 2025
I also noticed that the standard Base.show_type_name appears to be trimmable so we don't need the override. We might still want it for code size, but probably not a big deal. (cherry picked from commit 12f7bb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also noticed that the standard Base.show_type_name appears to be trimmable so we don't need the override. We might still want it for code size, but probably not a big deal.