[1.12] Backport (improve sysimage.mk more completely (#57758)) #59793
+37
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
building
vchuravy
force-pushed
the
vc/backport-debug
branch
from
e1fcd68 to
c72ea41
Compare
|
Not sure what I am supposed to review here. |
|
I tend to tag you as a reviewer for backports to make sure you see them. When I am backporting someone else's change, I prefer using a PR instead of a direct push to run CI over it. |
|
👍, however, I am not running CI on every individual commit I backport myself; that would take ages. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
Add back support for -debug builds and define ability to use shared library builds more places in the file. Fix #57675 (cherry picked from commit 51da540) Fixes #57675 (comment) and #57758 (comment) Co-authored-by: Jameson Nash <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
Add back support for -debug builds and define ability to use shared library builds more places in the file. Fix #57675 (cherry picked from commit 51da540) Fixes #57675 (comment) and #57758 (comment) Co-authored-by: Jameson Nash <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Oct 14, 2025
Add back support for -debug builds and define ability to use shared library builds more places in the file. Fix #57675 (cherry picked from commit 51da540) Fixes #57675 (comment) and #57758 (comment) Co-authored-by: Jameson Nash <[email protected]>
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back support for -debug builds and define ability to use shared
library builds more places in the file.
Fix #57675
(cherry picked from commit 51da540)
Fixes #57675 (comment)
and #57758 (comment)