change finalizer argument order to allow for do-block syntax #8775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebolewski
force-pushed
the
jcb/finalizer_order
branch
from
b46944c to
b732fc8
Compare
jakebolewski
force-pushed
the
jcb/finalizer_order
branch
from
b732fc8 to
89f3a12
Compare
Member
|
@jakebolewski I managed to fix the warning here. |
Member
|
(This now seems to be superseded by #12578) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #6454. There are some warnings due to method ambiguity errors when building the system image, I couldn't find a way to remove them while deprecating the old argument order.