-
Notifications
You must be signed in to change notification settings - Fork 23
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
There are currently two orthogonal issues with the library on Windows (spotted in jump-dev/Ipopt.jl#327 (comment)):
- the soversion of the library, fixed in
src/Make.incis stalling:but the latest release at the moment is v5.1.1libblastrampoline/src/Make.inc
Lines 26 to 28 in b829b0e
LBT_SOVERSION_MAJOR := 5 LBT_SOVERSION_MINOR := 0 LBT_SOVERSION_PATCH := 2 - generates the import library for
libblastrampoline/src/Makefile
Lines 45 to 46 in b829b0e
$(builddir)/$(LIB_FULL_VERSION): $(MAIN_OBJS) @$(call PRINT_CC,$(CC) -o "$@" $(call IMPLIB_FLAGS,$@) $(LBT_CFLAGS) $(SONAME_FLAG) $^ -shared $(LBT_LDFLAGS)) $@, which isLIB_FULL_VERSION, which is a bad idea because it means the ABI is broken in every single version (well, every single version where the soversion is actually bumped, see point above)
An overall solution is probably to stop generating the library with the full name on Windows, or at least generating the import library for LIB_MAJOR_VERSION instead of LIB_FULL_VERSION.
It remains the problem of actually remembering to update the soversion in src/Make.inc when doing a new release.
CC: @ViralBShah
amontoison
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working