- 
                Notifications
    You must be signed in to change notification settings 
- Fork 19
completing a phase #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      0cc797b
              
                atan(2) hypot clamp
              
              
                JeffreySarnoff 143d7d8
              
                bitstring BFloat16(Irrational)
              
              
                JeffreySarnoff 66642ed
              
                Update Project.toml
              
              
                JeffreySarnoff 3682602
              
                Update README.md
              
              
                JeffreySarnoff d6f43f7
              
                fix conflicts
              
              
                JeffreySarnoff 75db320
              
                Revert "fix conflicts"
              
              
                JeffreySarnoff e5b0bc4
              
                Merge branch 'master' into jas-complete
              
              
                ViralBShah 663b207
              
                Update bfloat16.jl
              
              
                ViralBShah File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| name = "BFloat16s" | ||
| uuid = "ab4f0b2a-ad5b-11e8-123f-65d77653426b" | ||
| authors = ["Keno Fischer <[email protected]>"] | ||
| authors = ["Keno Fischer <[email protected]>", "Jeffrey Sarnoff <[email protected]>"] | ||
| version = "0.5.1" | ||
|  | ||
| [deps] | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitions like this are not beneficial. The generic definitions work fine already: https://github.com/JuliaLang/julia/blob/48ddd2dc2859f41fc1a82876cc5654fb31d7b2ba/base/intfuncs.jl#L1269-L1272
By eagerly demoting to
FLoat32you're making it impossible for LLVM to emit instructions that would support operations like this, which is now possible after JuliaLang/julia#55486.Similar arguments can be made for other operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so this pre-dates the LLVM support. Should we clean up this package and perhaps remove the other operations of this nature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this PR in that case.