Skip to content

Conversation

@ven-k
Copy link
Contributor

@ven-k ven-k commented May 5, 2023

@aplavin
Copy link
Member

aplavin commented May 5, 2023

#90
Wasn't this fixed in PackageCompiler already at JuliaLang/PackageCompiler.jl#805 and JuliaLang/PackageCompiler.jl#767? I thought those fixes made #90 obsolete.

- this prevents clash of extension names
@ven-k ven-k force-pushed the fix-ext-names branch from f4ecc90 to 3e718c3 Compare May 5, 2023 14:29
@ven-k ven-k changed the title refactor: prefix parent package name to extension names Prefix parent package name to extension names May 5, 2023
@ven-k
Copy link
Contributor Author

ven-k commented May 5, 2023

I saw there were merge conflicts; so opened this.

Changes from PackageCompiler PR 805 aren't part of release yet1. That must be why I ran into this issue.
With PackageCompiler#master, I could build the sysimage despite the clash. So once that is released, these changes won't be essential.

However, it is still a better practice. Note that example in Pkg.jl's docs on extension, now prefixes parent package name2. So I'm keeping this open, if you want to merge it.

Footnotes

  1. https://github.com/JuliaLang/PackageCompiler.jl/compare/v2.1.5...master

  2. https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

@jw3126
Copy link
Member

jw3126 commented May 5, 2023

@ven-k if you bump the patch version, I can tag a release with this PR included.

@jw3126 jw3126 merged commit 14d03e4 into JuliaObjects:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants