Implement setindex for Base.ImmutableDict #217
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmatz
force-pushed
the
immutabledict
branch
from
e073818 to
7253b98
Compare
aplavin
reviewed
Oct 17, 2025
Author
|
I'm going to wait for the conversation on my PR to implement |
The design of Base.ImmutableDict allows the same key to be added again, which shadows the previously added value. Unfortunately, it still prints out all of the entries, including repeated keys. I thought this might be confusing, so I implemented it to remove the value if the key exists and then add the new value. Closes JuliaObjects#216
danielmatz
force-pushed
the
immutabledict
branch
from
7253b98 to
c10868e
Compare
Author
|
Based on the discussion about |
cstjean
approved these changes
Oct 26, 2025
cstjean
left a comment
cstjean
left a comment
There was a problem hiding this comment.
Uneasy about that one, but it's the Base behaviour...
Member
|
I suggest we wait for JuliaLang/julia#59880 to be approved, to make sure we won't need to change the semantics afterwards. |
Author
|
This isn't urgent for me at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design of Base.ImmutableDict allows the same key to be added again, which shadows the previously added value. Unfortunately, it still prints out all of the entries, including repeated keys. I thought this might be confusing, so I implemented it to remove the value if the key exists and then add the new value.
Closes #216