more Base lenses #69
more Base lenses #69
Conversation
aplavin
force-pushed
the
morelenses
branch
6 times, most recently
from
c06b711 to
a57cb70
Compare
|
Could you force-push less, please? Doing so makes Github loose track of history and comments... |
|
Interesting, I've always thought it's best to keep the commit history clean, without back and forth changes. That's why I tend to edit existing commits instead of creating new ones, to keep change history linear. |
|
I think the better way to achieve that are rebasing or squashing at the end. But I'm by no means a Git guru, just noticed that Github doesn't properly keep track of comment history and links with force pushes. It's not a big deal though. |
|
I also think there are some tradeoffs with github between nice looking git history and incremental reviewability. Personally, I prefer better reviewability. |
|
Anyway, is there anything else left regarding changes to this PR? |
jw3126
left a comment
jw3126
left a comment
There was a problem hiding this comment.
LGTM! Thanks these are nice additions especially fixing slice indexing!
3 participants
No description provided.