Skip to content

Fix findfirst usage for Julia 1.0 #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Fix findfirst usage for Julia 1.0 #661

merged 1 commit into from
Mar 15, 2019

Conversation

@tkf
Copy link
Member

@tkf tkf commented Mar 11, 2019 •
edited
Loading

Without this change, PyJulia (symbols_present == true) path of startup.jl in Windows yields

LoadError: LoadError: MethodError: no method matching findfirst(::Array{UInt16,1}, ::Int64)
Closest candidates are:
  findfirst(::Union{AbstractString, AbstractArray}) at array.jl:1661
  findfirst(!Matched::Function, ::Any) at array.jl:1735
  findfirst(::Any) at array.jl:1652
in expression starting at C:\Users\appveyor\.julia\packages\PyCall\RQjD7\src\startup.jl:41
in expression starting at C:\Users\appveyor\.julia\packages\PyCall\RQjD7\src\PyCall.jl:37

(see https://ci.appveyor.com/project/Keno/pyjulia/builds/22976283/job/gqgiddula060yi1e#L417 which is the result of tkf/pyjulia@7618f64 in JuliaPy/pyjulia#236)

After this change, PyJulia works: https://ci.appveyor.com/project/Keno/pyjulia/builds/22977464/job/3wko54kx8yyav91j#L395; tkf/pyjulia@1a2efe7

@tkf
Copy link
Member Author

tkf commented Mar 12, 2019

https://ci.appveyor.com/project/Keno/pyjulia/builds/23001057

@stevengj stevengj merged commit 75bba75 into JuliaPy:master Mar 15, 2019
@stevengj
Copy link
Member

stevengj commented Mar 15, 2019

Thanks!

tkf added a commit to tkf/pyjulia that referenced this pull request Mar 23, 2019
@tkf
Revert "Ignore failure of test_compiled_modules_no in Windows"
422b409 
This reverts commit a6d304a.

This test passes now as JuliaPy/PyCall.jl#661
is merged and released in PyCall v1.91.0.
@tkf tkf mentioned this pull request Mar 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tkf @stevengj