Skip to content

Conversation

@gdalle
Copy link

@gdalle gdalle commented Oct 30, 2025

In CompatHelper PR's, I have often had the case where

  • a package's compat is bumped in Project.toml
  • it stays the same in test/Project.toml because CompatHelper.main() does not include subdirs = ["", "test", "docs"]
  • the latest version is not therefore tested in the PR due to test compat bounds
  • the check still ends up green so the user may never know

This PR tries to correct course by making it more explicit that subdirs is among the most important options to customize in a realistic package. It is important because CompatHelper itself doesn't have a test/Project.toml and so we cannot directly demonstrate that inside its CompatHelper.yml file (although we could add docs).

Related:

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1a3b572) to head (3c590a4).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #533   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          406       403    -3     
=========================================
- Hits           406       403    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant