Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Conversation

@IanButterworth
Copy link
Contributor

Moving the @testset out of the child process here means it won't leak into the printing in Base tests like:

Statistics                               (5) |    95.59 |   3.37 |  3.5 |    6592.22 |  2666.43
      From worker 7:	Test Summary:              | Pass  Total   Time
      From worker 7:	threaded SuiteSparse tests |    1      1  29.8s
SuiteSparse                              (7) |   242.43 |   5.38 |  2.2 |   11184.90 |  2365.01

Noticed while reducing the noise in Base tests JuliaLang/julia#44444

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #63 (b33eab5) into master (f63732c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   89.26%   89.27%           
=======================================
  Files           5        5           
  Lines        1360     1361    +1     
=======================================
+ Hits         1214     1215    +1     
  Misses        146      146           
Impacted Files Coverage Δ
src/umfpack.jl 86.43% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63732c...b33eab5. Read the comment docs.

@DilumAluthge DilumAluthge requested a review from KristofferC March 5, 2022 22:49
@ViralBShah ViralBShah merged commit f31dc2e into JuliaSparse:master Apr 2, 2022
@IanButterworth IanButterworth deleted the ib/testset_org_tweak branch April 25, 2022 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants