Skip to content

Conversation

@nickrobinson251
Copy link
Member

@nickrobinson251 nickrobinson251 commented May 8, 2025

same as #319 but for the newly added test from #313

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.93%. Comparing base (484c23f) to head (ff8d922).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Aqua.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files          11       11           
  Lines         513      513           
=======================================
  Hits          446      446           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I must have missed that in the review

@lgoettgens lgoettgens enabled auto-merge (squash) May 8, 2025 15:46
@lgoettgens lgoettgens merged commit 07be761 into master May 8, 2025
20 of 23 checks passed
@lgoettgens lgoettgens deleted the npr-patch-1 branch May 8, 2025 15:47
@nickrobinson251
Copy link
Member Author

thanks for the quick merge!

@lgoettgens lgoettgens added the backport-0.8 Should be backported to a 0.8.x release label May 28, 2025
lgoettgens pushed a commit that referenced this pull request May 28, 2025
lgoettgens pushed a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-0.8 Should be backported to a 0.8.x release changelog: not needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants