Skip to content

Conversation

@omus
Copy link
Member

@omus omus commented Jun 14, 2017

Updates the code to make use of the invokelatestadded in JuliaLang/julia#19784

@omus
Copy link
Member Author

omus commented Jun 14, 2017

If for some reason people don't like that this package now depends on Compat I can always use:

if isdefined(Base, :invokelatest)
    invokelatest = Base.invokelatest
else
    function invokelatest(f::Function, args...)
        # Note that we need to QuoteNode args to handle Symbols in args.
        eval(Expr(:call, f, map(QuoteNode, args)...))
    end
end

@rofinn
Copy link
Collaborator

rofinn commented Jun 14, 2017

IMHO, Compat seems like a pretty minimal dependency given that Mocking is supporting 4 different julia versions.

@omus omus merged commit 1645d39 into master Jun 14, 2017
@omus omus deleted the cv/invokelatest branch June 14, 2017 19:50
@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #20   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files           2       2           
  Lines         162     162           
======================================
  Hits          151     151           
  Misses         11      11
Impacted Files Coverage Δ
src/Mocking.jl 87.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b9c7a...c8295ac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants