Correct ID attribute and add hostname attribute #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
===========================================
- Coverage 99.68% 75.50% -24.19%
===========================================
Files 5 4 -1
Lines 318 298 -20
===========================================
- Hits 317 225 -92
- Misses 1 73 +72
Continue to review full report at Codecov.
|
oxinabox
approved these changes
Dec 30, 2020
Member
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
Concept seems sounds.
Merge once CI is passing?
mmiller-max
force-pushed
the
mm/ids-and-hostname
branch
from
4ee8172 to
2c4855d
Compare
Member
Author
|
Will do, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we just remove all attributes from
testsuites?Closes #56