fix: common integration tests issues #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
approved these changes
Jul 4, 2022
Member
ntn-x2
left a comment
ntn-x2
left a comment
There was a problem hiding this comment.
I wish I had saved those hours 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#2040
Errors happening during the initialization steps of integration tests should not be silenced, this has complicated debugging for me and @ntn-x2.
The new mode of running integration tests against a single node (introduced in #558 by @rflechtner) does not support running tests in parallel, and now will inform the developer who tries that.
How to test:
env TEST_WS_ADDRESS=foo yarn test:integration
Checklist: