refactor(modeling-cmds)!: label optional, dupes now fail #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jessfraz
commented
Sep 17, 2025
jessfraz
commented
- label becomes Option instead of empty String, serde updated, this is just more consistent w the rest of the api
- test now asserts duplicate Python stub class and enum names
- label becomes Option<String> instead of empty String, serde updated - test now asserts duplicate Python stub class and enum names Signed-off-by: Jessie Frazelle <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage ? 26.19%
=======================================
Files ? 35
Lines ? 1714
Branches ? 0
=======================================
Hits ? 449
Misses ? 1265
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamwaffles
approved these changes
Sep 17, 2025
Contributor
jamwaffles
left a comment
jamwaffles
left a comment
There was a problem hiding this comment.
Cc @mlfarrell and #936
Co-authored-by: James Waples <[email protected]>
Signed-off-by: Jessie Frazelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.