Set the surface values appropriately for cloned objects #8525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
July 24, 2025 15:27
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Performance ReportMerging #8525 will improve performances by 10.25%Comparing Summary
Benchmarks breakdown
Footnotes
|
added 2 commits
October 9, 2025 17:55
…eling-app into serena/cloning-set-surfaces
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
added 2 commits
November 13, 2025 13:41
jtran
reviewed
Nov 13, 2025
Co-authored-by: Jonathan Tran <[email protected]>
jtran
approved these changes
Nov 13, 2025
adamchalmers
pushed a commit
that referenced
this pull request
Nov 14, 2025
* update snapshot * update surfaces of clones * fmt and clippy * unfix clipppy sryyy * Fix lint * fmt * udpate according to suggestions * udpate according to suggestions * fix excessive if let * stopping point * update close fn * update samples * clippy fix * update snapshots, clean up optioonal handling * fmt * stopping poiint in case i mess things up * this version works? * revert kcl file * fmt * overwrite sls and saturn tests * clippy fix * clippy fix * only use map if its there * fmt * add warning * add warning * cleanup * Update snapshots * revert * Update rust/kcl-lib/src/std/extrude.rs Co-authored-by: Jonathan Tran <[email protected]> * make install --------- Co-authored-by: gserena <[email protected]> Co-authored-by: Adam Sunderland <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan Tran <[email protected]> Co-authored-by: Jace Browning <[email protected]>
adamchalmers
pushed a commit
that referenced
this pull request
Nov 14, 2025
* update snapshot * update surfaces of clones * fmt and clippy * unfix clipppy sryyy * Fix lint * fmt * udpate according to suggestions * udpate according to suggestions * fix excessive if let * stopping point * update close fn * update samples * clippy fix * update snapshots, clean up optioonal handling * fmt * stopping poiint in case i mess things up * this version works? * revert kcl file * fmt * overwrite sls and saturn tests * clippy fix * clippy fix * only use map if its there * fmt * add warning * add warning * cleanup * Update snapshots * revert * Update rust/kcl-lib/src/std/extrude.rs Co-authored-by: Jonathan Tran <[email protected]> * make install --------- Co-authored-by: gserena <[email protected]> Co-authored-by: Adam Sunderland <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan Tran <[email protected]> Co-authored-by: Jace Browning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of https://github.com/KittyCAD/engine/pull/3380