Extrude accepts Sketches, Faces, and Tagged Faces #8661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
July 24, 2025 15:27
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
added 3 commits
October 23, 2025 15:08
added 3 commits
October 23, 2025 15:40
added 4 commits
November 3, 2025 09:48
…ling-app into serena/sketch-face-facetag
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
added 3 commits
November 3, 2025 10:09
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
adamchalmers
added a commit
that referenced
this pull request
Nov 4, 2025
The "clean up type string" logic [here](https://github.com/KittyCAD/modeling-app/blob/achalmers/array-of-unions/rust/kcl-lib/src/docs/gen_std_tests.rs#L517) is a bit complicated, and it doesn't support arrays of unions. IMO it's difficult to do both formatting and parsing of KCL types in the same function. A better approach would be to recursively parse the type into a tree structure (where arrays have a subtype, and unions have multiple subtypes), then format that tree. This PR: - Adds unit tests for the cleanup_type_string function, in the first commit. - Adds a new proper recursive parser for KCL type strings (parses them into a tree) - Changes the KCL type formatter `cleanup_type_string` to use this parsed tree, rather than adhoc string processing. This includes changes to the unit tests added in the first commit. - Updates all the docs This has some very slight changes to the resulting Markdown, which should be easy to see. They're basically change how arrays are nested in their markdown links. As a side-effect this should nicely render arrays of unions in types, such as the ones Serena's adding in her [PR](#8661). Old: the Markdown link contains a `[string]` in its text New: the Markdown link is just around `string`, and the surrounding array braces are outside the link.
Contributor
Author
|
This is primarily holding for engine changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes