Support tagged not null marks #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwarDDay
force-pushed
the
tagged_not_null_mark
branch
from
6fd6cc9 to
8fb5ea4
Compare
Member
|
These classes do not have any documentation and are meant for internal use, not for public API. Are you sure that they fit your needs? |
Contributor
Author
|
It's working quite good and I had no problems so far. It's a key-value-store in the background, so I oriented on the |
Member
|
Ok then. But remember that this class is subject to change without further notice and one day you may need to copy it anyway |
sandwwraith
reviewed
Jun 2, 2022
formats/json/commonMain/src/kotlinx/serialization/json/internal/TreeJsonEncoder.kt
Show resolved
Hide resolved
EdwarDDay
force-pushed
the
tagged_not_null_mark
branch
from
8fb5ea4 to
cdd391f
Compare
EdwarDDay
force-pushed
the
tagged_not_null_mark
branch
from
cdd391f to
2f6a276
Compare
sandwwraith
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to override the not null mark behavior of the tagged encoder. I would like to override it and add an additional parameter
$isNullwith my custom format. This way I can better support nullability.