Add stable hashCode() calculation to PrimitiveSerialDescriptor #2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You're right; all descriptors should have meaningful equals. Can you please also add a test? |
Contributor
Author
|
I've added tests |
sandwwraith
requested changes
Dec 27, 2022
Member
sandwwraith
left a comment
sandwwraith
left a comment
There was a problem hiding this comment.
Thank you! Just move tests out of internal package, please
core/commonTest/src/kotlinx/serialization/internal/PrimitiveSerialDescriptorTest.kt
Outdated
Show resolved
Hide resolved
… tests out of internal package Fix Kotlin#2135
sandwwraith
approved these changes
Dec 29, 2022
Member
|
This should have been opened against |
Member
|
It's better to merge master into dev instead to avoid duplicate commits while still being in the same repository state eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2135