Fix #2218: NoSuchMethodError when parsing a JSON stream on Java 8 #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhead
force-pushed
the
issues/2218-cast
branch
from
ade34f2 to
0605639
Compare
shanshin
reviewed
Mar 7, 2023
formats/json/jvmMain/src/kotlinx/serialization/json/internal/CharsetReader.kt
Show resolved
Hide resolved
madhead
force-pushed
the
issues/2218-cast
branch
from
0605639 to
fda2163
Compare
madhead
force-pushed
the
issues/2218-cast
branch
from
fda2163 to
4977da4
Compare
shanshin
approved these changes
Mar 8, 2023
Contributor
shanshin
left a comment
shanshin
left a comment
There was a problem hiding this comment.
Thanks for the research!
sandwwraith
pushed a commit
that referenced
this pull request
Aug 2, 2023
There are 7 methods in ByteBuffer that have the problem described in #2218 and was attempted to be fixed in #2219. Unfortunately, the fix in #2219 was incomplete as another of these 7 methods is used in the same class. Also it could happen anytime and with similar cases, that this happens again and is only recognized very late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a test for this one would be tricky as it would require compiling the library with Java 9+ and running a single test on Java 8.
Instead of that one could use the minimal reproducible example repository (https://github.com/madhead/kotlinx-serialization-json-java8) to validate a fix locally 😅