Fixed regression with serialization using list parametrized with contextual types #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extual types Fixes #2323 In the current implementation of serializer lookup caching, if the serializer for the parameter was not found, the `serializerOrNull` function always returned null, without further searching for contextual serializers in the current SerializersModule.
sandwwraith
requested changes
Jun 13, 2023
formats/json-tests/commonTest/src/kotlinx/serialization/SerializersLookupTest.kt
Outdated
Show resolved
Hide resolved
formats/json-tests/commonTest/src/kotlinx/serialization/SerializersLookupTest.kt
Outdated
Show resolved
Hide resolved
sandwwraith
approved these changes
Jun 13, 2023
JesusMcCloud
pushed a commit
to a-sit-plus/kotlinx.serialization
that referenced
this pull request
Jul 5, 2023
…extual types (Kotlin#2331) Fixes Kotlin#2323 In the current implementation of serializer lookup caching, if the serializer for the parameter was not found, the `serializerOrNull` function always returned null, without further searching for contextual serializers in the current SerializersModule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2323
In the current implementation of serializer lookup caching, if the serializer for the parameter was not found, the
serializerOrNullfunction always returned null, without further searching for contextual serializers in the current SerializersModule.