-
Notifications
You must be signed in to change notification settings - Fork 421
Add ublox_msg_filters package with exact time synchronization construct #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ublox_msg_filters package with exact time synchronization construct #154
Conversation
|
I plan to provide something similar for the ROS2 branch in the next couple months |
|
Thanks for the PR. I had a quick look and have a few questions.
|
|
Regarding the license, this package is missing a LICENSE file but has license header in some files. |
|
It is a port of that filter. The Additionally, a user is most likely interested in all ublox messages that were created based on the same measurement update (which is specified by |
|
The cmake could be changed to be more similar to the existing packages. I'll defer to someone else's judgement on what to put in the license headers. |
|
Thanks for the explanation, that makes sense. For the license on exact_time.h, I'm almost certain you need to keep the original willow garage one. |
|
Okay, I'll use the Willow Garage one in the header and remove the license in the example cpp. Should I keep |
|
Are you using any 17 features by any chance? If not I suggest you change it to 11 to be compatible with the rest of the packages. |
|
I'd prefer to remove it instead of specifying 11. The message_filters version doesn't specify, and I don't think it's using anything added in 11 or 17: |
|
Sounds good. |
…ith iTOW to get a single callback Rename iTOW field of NavRELPOSNED messages to be the same as all other Nav messages
92d7242 to
d0f2062
Compare
I wasn't sure about the license when adding a new package, so I copied the license header from other source code in this repository