-
Notifications
You must be signed in to change notification settings - Fork 1
Convert loke context to a PeerDep #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the version used by the CI so it's the version I pinned it to to prevent a massive update to package-lock.json with the wrong npm version
1e36b2e
to
d9a21c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
essentially a copy / paste of the npm-publish workflow, except this one runs on PRs and won't publish the package
d9a21c6
to
de61441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of docs between different versions makes things much harder to figure out when bumping versions
de61441
to
8cf3786
Compare
8cf3786
to
50c185c
Compare
Internal change only
Something annoying I noticed whilst updating this dep within ordering is that pinning this to a specific version can cause annoyances when attempting to update. I looked through the history of this repo and found comments in this PR: #29 stating that the only reason loke context wasn't a peer dep in the first place was due to the package only having a single version at the time. Currently, the only 2 versions published are
0.0.1
and0.1.0
(src: npmjs), so I pinned the versions to being at least 0.0.1 and less than v1.Blocking: https://github.com/LOKE/ordering/pull/295
Submitter Checklist
Check only those that apply to this change.
Testing Evidence
What evidence supports that you have tested this change?
Reviewer Checklist
Note: if this PR affects authentication or payments please seek a secondary tester.