Refactor time picker #151
Merged
Refactor time picker #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qroll
commented
May 17, 2023
| <Container | ||
| ref={resizeDetector.ref} | ||
| data-testid={getTestId("timepicker-dropdown")} | ||
| inert={show ? undefined : ""} |
There was a problem hiding this comment.
when set, the inert attribute disables interactivity with the element and its children. this includes exclusion from the tab sequence
it's supported in the majority of browsers now but unfortunately still not included in React, so a workaround is to augment the types and whitelist it from eslint
keithtxw
requested changes
May 18, 2023
|
Can we also change the |
added 13 commits
May 18, 2023 14:00
qroll
force-pushed
the
refactor-time-picker
branch
from
d931d29 to
dc1db1c
Compare
qroll
force-pushed
the
refactor-time-picker
branch
from
dc1db1c to
ffd81f1
Compare
qroll
commented
May 18, 2023
| document.removeEventListener("mousedown", handleMouseDownEvent); | ||
| document.removeEventListener("keyup", handleKeyUpEvent); | ||
| }; | ||
| }, [showEndTimeSelector]); |
There was a problem hiding this comment.
I missed out on this during review. these callbacks have stale state. have also amended similar issues in Timepicker
keithtxw
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactoring/updating time picker inputs
utilsfolder and renamed toTimeHelperOther changes
InputWrapperInputWrapperAdditional information