[#810][VL]Decouple Filter desktop and mobile variants #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qroll
reviewed
Oct 28, 2025
Contributor
qroll
left a comment
qroll
left a comment
There was a problem hiding this comment.
requests:
- include new unit tests for the standalone components
- document the new standalone components in the
props-table.tsx
qroll
requested changes
Oct 29, 2025
qroll
requested changes
Oct 30, 2025
qroll
requested changes
Oct 31, 2025
Contributor
|
observed this styling issue. the styles need to be decoupled too. It should maintain the desktop styling in Sidebar and mobile styling in Modal 
|
qroll
requested changes
Nov 4, 2025
qroll
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Additional information