Rename LightningLite (1/n) #15932

awaelchli · 2022-12-07T08:51:08Z

What does this PR do?

Rebranding 🎉
This PR renames the Lightning Lite class and references to it in all places of the code base.
Parts 2/n etc. will rename package, files, tests, and other variables.

Does your PR introduce any breaking changes? If yes, please list them.

Yes. Backward compatibility will be addressed separately.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

for more information, see https://pre-commit.ci

…ebug-refactor

for more information, see https://pre-commit.ci

github-actions · 2022-12-07T13:06:39Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, src/pytorch_lightning/lite/lite.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/lite/lite.py, src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, src/pytorch_lightning/lite/lite.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, src/pytorch_lightning/lite/lite.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/lite/lite.py, docs/source-pytorch/starter/lightning_lite.rst.

🟢 lightning_lite: CPU workflow

Check ID	Status
lite-cpu (macOS-11, lite, 3.8, 1.11)	success	✅
lite-cpu (macOS-11, lite, 3.9, 1.12)	success	✅
lite-cpu (macOS-11, lite, 3.10, 1.13)	success	✅
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (windows-2022, lite, 3.9, 1.11)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.12)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.13)	success	✅
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
lite-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, tests/tests_lite/helpers/models.py, tests/tests_lite/plugins/precision/test_native_amp_integration.py, tests/tests_lite/strategies/test_deepspeed_integration.py, tests/tests_lite/strategies/test_fsdp_integration.py, tests/tests_lite/test_connector.py, tests/tests_lite/test_lite.py, tests/tests_lite/test_parity.py, tests/tests_lite/test_wrappers.py.

🟢 lightning_lite: Azure GPU

Check ID	Status
lightning-lite (GPUs)	success	✅

These checks are required after the changes to examples/lite/image_classifier_2_lite.py, src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, tests/tests_lite/helpers/models.py, tests/tests_lite/plugins/precision/test_native_amp_integration.py, tests/tests_lite/strategies/test_deepspeed_integration.py, tests/tests_lite/strategies/test_fsdp_integration.py, tests/tests_lite/test_connector.py, tests/tests_lite/test_lite.py, tests/tests_lite/test_parity.py, tests/tests_lite/test_wrappers.py.

🟡 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	no_status	❓
app-pytest (macOS-11, app, 3.8, oldest)	no_status	❓
app-pytest (macOS-11, lightning, 3.9, latest)	no_status	❓
app-pytest (ubuntu-20.04, app, 3.8, latest)	no_status	❓
app-pytest (ubuntu-20.04, app, 3.8, oldest)	no_status	❓
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	no_status	❓
app-pytest (windows-2022, app, 3.8, latest)	no_status	❓
app-pytest (windows-2022, app, 3.8, oldest)	no_status	❓
app-pytest (windows-2022, lightning, 3.8, latest)	no_status	❓

These checks are required after the changes to src/lightning_app/utilities/introspection.py.

🟡 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	no_status	❓
app-examples (macOS-11, app, 3.9, oldest)	no_status	❓
app-examples (macOS-11, lightning, 3.9, latest)	no_status	❓
app-examples (ubuntu-20.04, app, 3.9, latest)	no_status	❓
app-examples (ubuntu-20.04, app, 3.9, oldest)	no_status	❓
app-examples (ubuntu-20.04, lightning, 3.9, latest)	no_status	❓
app-examples (windows-2022, app, 3.9, latest)	no_status	❓
app-examples (windows-2022, app, 3.9, oldest)	no_status	❓
app-examples (windows-2022, lightning, 3.9, latest)	no_status	❓

These checks are required after the changes to src/lightning_app/utilities/introspection.py, examples/app_multi_node/train_lite.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning_app/utilities/introspection.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/utilities/introspection.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/__init__.py, src/lightning_app/utilities/introspection.py, src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, src/pytorch_lightning/lite/lite.py.

🔴 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, app, 3.10)	cancelled	🚫
install-pkg (ubuntu-22.04, lite, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, lite, 3.10)	cancelled	🚫
install-pkg (ubuntu-22.04, pytorch, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, pytorch, 3.10)	cancelled	🚫
install-pkg (ubuntu-22.04, lightning, 3.7)	cancelled	🚫
install-pkg (ubuntu-22.04, lightning, 3.10)	cancelled	🚫
install-pkg (macOS-12, app, 3.7)	cancelled	🚫
install-pkg (macOS-12, app, 3.10)	cancelled	🚫
install-pkg (macOS-12, lite, 3.7)	cancelled	🚫
install-pkg (macOS-12, lite, 3.10)	cancelled	🚫
install-pkg (macOS-12, pytorch, 3.7)	cancelled	🚫
install-pkg (macOS-12, pytorch, 3.10)	cancelled	🚫
install-pkg (macOS-12, lightning, 3.7)	cancelled	🚫
install-pkg (macOS-12, lightning, 3.10)	cancelled	🚫
install-pkg (windows-2022, app, 3.7)	cancelled	🚫
install-pkg (windows-2022, app, 3.10)	cancelled	🚫
install-pkg (windows-2022, lite, 3.7)	cancelled	🚫
install-pkg (windows-2022, lite, 3.10)	cancelled	🚫
install-pkg (windows-2022, pytorch, 3.7)	cancelled	🚫
install-pkg (windows-2022, pytorch, 3.10)	cancelled	🚫
install-pkg (windows-2022, lightning, 3.7)	cancelled	🚫
install-pkg (windows-2022, lightning, 3.10)	cancelled	🚫

These checks are required after the changes to src/lightning/__init__.py, src/lightning_app/utilities/introspection.py, src/lightning_lite/__init__.py, src/lightning_lite/cli.py, src/lightning_lite/connector.py, src/lightning_lite/lite.py, src/lightning_lite/plugins/io/torch_io.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/strategies/strategy.py, src/lightning_lite/utilities/distributed.py, src/lightning_lite/wrappers.py, src/pytorch_lightning/lite/lite.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton

LGTM !

awaelchli and others added 13 commits December 7, 2022 01:46

rename class and brand name

3bc6f5f

[pre-commit.ci] auto fixes from pre-commit.com hooks

452c40a

for more information, see https://pre-commit.ci

update

b20c83c

Merge remote-tracking branch 'origin/lite/debug-refactor' into lite/d…

7d0abe8

…ebug-refactor

fix doctest

4162d13

[pre-commit.ci] auto fixes from pre-commit.com hooks

fdc4f06

for more information, see https://pre-commit.ci

update

346ace7

update examples

ab6625f

fix references

34c561d

line too long

8203659

f401

ac770cd

fix

338b3d8

update

9485b13

awaelchli marked this pull request as ready for review December 7, 2022 13:06

awaelchli requested review from Borda, carmocca, edenlightning, ethanwharris, hhsecond, justusschock, lantiga, tchaton and williamFalcon as code owners December 7, 2022 13:06

awaelchli mentioned this pull request Dec 7, 2022

Rename LightningLite (2/n) #15938

Merged

11 tasks

tchaton approved these changes Dec 7, 2022

View reviewed changes

tchaton merged commit 4f8394e into lite/debug Dec 7, 2022

tchaton deleted the lite/debug-refactor branch December 7, 2022 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename LightningLite (1/n) #15932

Rename LightningLite (1/n) #15932

Uh oh!

awaelchli commented Dec 7, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Dec 7, 2022 •

edited

Loading

Uh oh!

tchaton left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rename LightningLite (1/n) #15932

Rename LightningLite (1/n) #15932

Uh oh!

Conversation

awaelchli commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

Uh oh!

github-actions bot commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⛈️ Required checks status: Has failure 🔴

Groups summary

Uh oh!

tchaton left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

awaelchli commented Dec 7, 2022 •

edited

Loading

github-actions bot commented Dec 7, 2022 •

edited

Loading