Deprecate nvidia/apex #16039

carmocca · 2022-12-13T16:14:46Z

What does this PR do?

Fixes #14416

PyTorch Lightning package changes:

Removes apex from the docs and the deprecated pieces below
Updates tests to avoid the deprecation messages, or catch them
Deprecates NativeMixedPrecisionPlugin in favor of MixedPrecisionPlugin
Deprecates the LightningModule.optimizer_step(..., using_native_amp=bool) argument
Deprecates Trainer(amp_backend)
Deprecates Trainer.amp_backend
Deprecates Trainer(amp_level). This was already deprecated but the previous deprecation has been replaced with the one in this PR for consistency.
Deprecates the ApexMixedPrecisionPlugin. The deprecation message triggered by Apex internally is replaced by ours.
Deprecates the AMPType enum and updates the codebase to avoid it. The _DeprecatedEnumMeta class is re-introduced to do this.
Deprecates DeepSpeedPrecisionPlugin(amp_type, amp_level) arguments.

Lite package changes:

Renames the NativeMixedPrecision class to MixedPrecision
Removes DeepSpeedPrecision(amp_type, amp_level) arguments and their support
Remvoes the AMPType enum and its uses.

Follow-up items (out of scope for this PR):

Remove native_ from the appropriate filenames
Remove "Native" from the FSDP class names

Does your PR introduce any breaking changes? If yes, please list them.

None intended

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton @carmocca @justusschock @awaelchli

src/pytorch_lightning/plugins/precision/native_amp.py

github-actions · 2022-12-20T00:35:04Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_ddp_fork_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_native_amp.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_ddp_fork_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_native_amp.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_imports.py, src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_ddp_fork_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_native_amp.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_ddp_fork_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_native_amp.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py, docs/source-pytorch/accelerators/gpu_intermediate.rst, docs/source-pytorch/api_references.rst, docs/source-pytorch/common/checkpointing_basic.rst, docs/source-pytorch/common/optimization.rst, docs/source-pytorch/common/precision_intermediate.rst, docs/source-pytorch/common/trainer.rst, docs/source-pytorch/conf.py, docs/source-pytorch/extensions/plugins.rst, docs/source-pytorch/model/manual_optimization.rst.

🟢 lightning_lite: CPU workflow

Check ID	Status
lite-cpu (macOS-11, lite, 3.8, 1.11)	success	✅
lite-cpu (macOS-11, lite, 3.9, 1.12)	success	✅
lite-cpu (macOS-11, lite, 3.10, 1.13)	success	✅
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (windows-2022, lite, 3.9, 1.11)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.12)	success	✅
lite-cpu (windows-2022, lite, 3.10, 1.13)	success	✅
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest)	success	✅
lite-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
lite-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, tests/tests_lite/plugins/precision/test_deepspeed.py, tests/tests_lite/plugins/precision/test_native_amp.py, tests/tests_lite/test_connector.py.

🟢 lightning_lite: Azure GPU

Check ID	Status
lightning-lite (GPUs)	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, tests/tests_lite/plugins/precision/test_deepspeed.py, tests/tests_lite/plugins/precision/test_native_amp.py, tests/tests_lite/test_connector.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, lite, 3.7)	success	✅
install-pkg (ubuntu-22.04, lite, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, lite, 3.7)	success	✅
install-pkg (macOS-12, lite, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, lite, 3.7)	success	✅
install-pkg (windows-2022, lite, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_lite/connector.py, src/lightning_lite/plugins/__init__.py, src/lightning_lite/plugins/precision/__init__.py, src/lightning_lite/plugins/precision/deepspeed.py, src/lightning_lite/plugins/precision/fsdp.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/strategies/deepspeed.py, src/lightning_lite/utilities/__init__.py, src/lightning_lite/utilities/enums.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/lite/lite.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/fsdp_native_native_amp.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/plugins/precision/sharded_native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/configuration_validator.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, src/pytorch_lightning/utilities/imports.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Borda

🦦

carmocca self-assigned this Dec 13, 2022

github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 13, 2022

carmocca added deprecation Includes a deprecation precision: apex (removed) NVIDIA/apex precision labels Dec 13, 2022

carmocca added this to the v1.9 milestone Dec 13, 2022

carmocca commented Dec 13, 2022

View reviewed changes

src/pytorch_lightning/plugins/precision/native_amp.py Show resolved Hide resolved

carmocca added 5 commits December 19, 2022 16:55

WIP

45315e1

WIP

d5a14b0

using_native_amp

e5d665b

amp_backend and amp_level

c4078f2

Fix tests

15ed1ce

carmocca force-pushed the depreaction/apex branch from 024d6dc to 15ed1ce Compare December 19, 2022 15:55

Update docs

ea40f56

carmocca force-pushed the depreaction/apex branch from 2f286e1 to ea40f56 Compare December 19, 2022 17:18

carmocca added 6 commits December 20, 2022 00:36

Deprecation tests

457fa8e

Fix plugin tests

82095db

CHANGELOG

bdb77b0

Fixes

135a734

Trainer.amp_backend. Tests

475bcf5

Non-deprecated attr

645db8c

carmocca marked this pull request as ready for review December 20, 2022 00:33

carmocca requested review from Borda, awaelchli, edenlightning, justusschock, tchaton and williamFalcon as code owners December 20, 2022 00:33

awaelchli approved these changes Dec 20, 2022

View reviewed changes

carmocca changed the title ~~[WIP] Deprecate nvidia/apex~~ Deprecate nvidia/apex Dec 20, 2022

carmocca enabled auto-merge (squash) December 20, 2022 01:31

Fixes

e24f958

carmocca force-pushed the depreaction/apex branch from 60683d6 to e24f958 Compare December 20, 2022 01:59

Non-standalone

66379cd

Borda reviewed Dec 20, 2022

View reviewed changes

justusschock approved these changes Dec 20, 2022

View reviewed changes

carmocca merged commit 14f441c into master Dec 20, 2022

carmocca deleted the depreaction/apex branch December 20, 2022 10:09

mergify bot added the ready PRs ready to be merged label Dec 20, 2022

carmocca added a commit that referenced this pull request Dec 20, 2022

Deprecate nvidia/apex (#16039)

4960f53

carmocca added a commit that referenced this pull request Dec 20, 2022

Deprecate nvidia/apex (#16039)

214c2eb

carmocca added a commit that referenced this pull request Dec 20, 2022

Deprecate nvidia/apex (#16039)

113176b

carmocca added a commit that referenced this pull request Dec 20, 2022

Deprecate nvidia/apex (#16039)

6ce4c77

carmocca added a commit that referenced this pull request Dec 20, 2022

Deprecate nvidia/apex (#16039)

9dea1c3

nicolai86 pushed a commit that referenced this pull request Dec 20, 2022

Deprecate nvidia/apex (#16039)

12e5ec9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Deprecate nvidia/apex #16039

Deprecate nvidia/apex #16039

Uh oh!

carmocca commented Dec 13, 2022 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

github-actions bot commented Dec 20, 2022 •

edited

Loading

Uh oh!

Borda left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Deprecate nvidia/apex #16039

Deprecate nvidia/apex #16039

Uh oh!

Conversation

carmocca commented Dec 13, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Follow-up items (out of scope for this PR):

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Uh oh!

Uh oh!

github-actions bot commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Required checks status: All passing 🟢

Groups summary

Uh oh!

Borda left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

carmocca commented Dec 13, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 20, 2022 •

edited

Loading

Borda left a comment •

edited

Loading