-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fixes in sphinx docs links #16255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in sphinx docs links #16255
Conversation
…ning into fix-sphinx-docs-links
|
@Borda @awaelchli This is ready for review. The kornia.org link in |
…ning into fix-sphinx-docs-links
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comments addressed
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Fixes links referred to in #16234.
Fixes #8107
Fixed the following links
common/lightning_module.rstLinkmake_pruning_permanent()in ModelPruning Callbacklincheck_ignoreinconf.pyFix the following links
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃