Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 11, 2024

What does this PR do?

Python 3.8 reaches end-of-life in October 2024. In addition, PyTorch has now support for Python 3.12 (including dynamo) so I propose to shift our Python support window. This PR drops 3.8 and a future PR will add 3.12.


📚 Documentation preview 📚: https://pytorch-lightning--20071.org.readthedocs.build/en/20071/

cc @carmocca @Borda @justusschock @awaelchli

@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Jul 11, 2024
@awaelchli awaelchli added tests and removed fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Jul 11, 2024
@awaelchli awaelchli added this to the 2.4 milestone Jul 11, 2024
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Jul 11, 2024
@awaelchli awaelchli added the fun Staff contributions outside working hours - to differentiate from the "community" label label Jul 11, 2024
@awaelchli awaelchli marked this pull request as ready for review July 11, 2024 18:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success
pl-cpu (macOS-14, lightning, 3.10, 2.1) success
pl-cpu (macOS-14, lightning, 3.10, 2.2) success
pl-cpu (macOS-14, lightning, 3.10, 2.3) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3) success
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.10, 2.2) success
pl-cpu (windows-2022, lightning, 3.10, 2.3) success
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/pytorch/trainer/connectors/signal_connector.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/signal_connector.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success
fabric-cpu (macOS-14, lightning, 3.11, 2.1) success
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success
fabric-cpu (macOS-14, lightning, 3.10, 2.3) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, tests/tests_fabric/utilities/test_registry.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, tests/tests_fabric/utilities/test_registry.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/pytorch/trainer/connectors/signal_connector.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.9) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.9) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.9) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, fabric, 3.9) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.9) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.9) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.9) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.9) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.9) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.9) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.9) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to .github/workflows/ci-pkg-install.yml, src/lightning/__setup__.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/pytorch/trainer/connectors/signal_connector.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91%. Comparing base (bf25167) to head (3c4454f).
Report is 61 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20071   +/-   ##
=======================================
  Coverage      91%      91%           
=======================================
  Files         266      266           
  Lines       22956    22948    -8     
=======================================
- Hits        20784    20781    -3     
+ Misses       2172     2167    -5     

@awaelchli awaelchli merged commit 9987d99 into master Jul 12, 2024
@awaelchli awaelchli deleted the removal/python38 branch July 12, 2024 14:33
weiji14 added a commit to regro-cf-autotick-bot/lightning-feedstock that referenced this pull request Aug 7, 2024
Python 3.8 support was removed in Lightning-AI/pytorch-lightning#20071, and runtime dependency on NumPy was removed in Lightning-AI/pytorch-lightning#20090
weiji14 added a commit to conda-forge/lightning-feedstock that referenced this pull request Aug 7, 2024
* updated v2.4.0

* MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.37.2, and conda-forge-pinning 2024.08.07.04.40.03

* Bump minimum version of Python to 3.9 and drop numpy

Python 3.8 support was removed in Lightning-AI/pytorch-lightning#20071, and runtime dependency on NumPy was removed in Lightning-AI/pytorch-lightning#20090

---------

Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label package pl Generic label for PyTorch Lightning package tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants