-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: rich progress bar error when resume training #21000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Borda
merged 8 commits into
Lightning-AI:master
from
deependujha:fix/rich-progress-bar-in-resume
Jul 31, 2025
Merged
fix: rich progress bar error when resume training #21000
Borda
merged 8 commits into
Lightning-AI:master
from
deependujha:fix/rich-progress-bar-in-resume
Jul 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@deependujha, mind check the failing tests:
|
@Borda all tests pass now. |
bhimrazy
reviewed
Jul 28, 2025
Borda
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20976 #21015
Fixes an issue where the rich progress bar was not initialized when resuming training mid-epoch.
This occurred because
on_train_epoch_start
is not called during such resumes. The progress bar is now initialized inon_train_start
to ensure correct behavior.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21000.org.readthedocs.build/en/21000/