Skip to content

fix: rich progress bar error when resume training #21000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deependujha
Copy link
Collaborator

@deependujha deependujha commented Jul 25, 2025

What does this PR do?

Fixes #20976 #21015

Fixes an issue where the rich progress bar was not initialized when resuming training mid-epoch.

This occurred because on_train_epoch_start is not called during such resumes. The progress bar is now initialized in on_train_start to ensure correct behavior.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21000.org.readthedocs.build/en/21000/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 25, 2025
@Borda
Copy link
Member

Borda commented Jul 25, 2025

@deependujha, mind check the failing tests:

FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_leave[False-3] - assert 4 == 3
 +  where 4 = <function reset at 0x1496c07c0>.call_count
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[4-6-6-5] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_reset_bars - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[3-1-0-1] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[3-1-1-3] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_refresh_rate_disabled - AssertionError
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_custom_theme - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[1-2-3-6] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[3-6-6-5] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[3-5-0-2] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[3-5-2-4] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_disabled - AssertionError
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[7-6-6-3] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[6-5-2-3] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.
FAILED callbacks/progress/test_rich_progress_bar.py::test_rich_progress_bar_with_refresh_rate[1-0-0-0] - TypeError: The `RichProgressBar._trainer` reference has not been set yet.

@deependujha
Copy link
Collaborator Author

@Borda all tests pass now.

@Borda Borda merged commit 6a5c946 into Lightning-AI:master Jul 31, 2025
83 checks passed
@deependujha deependujha deleted the fix/rich-progress-bar-in-resume branch August 1, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich progress bar error when resume training
3 participants