update nightly & upgrade Twine #5458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SeanNaren,
awaelchli,
justusschock,
tchaton and
williamFalcon
as code owners
Collaborator
Author
|
FYI, I have opened an issue for failing uploading nightly releases pypa/gh-action-pypi-publish#53 |
Borda
requested review from
SkafteNicki,
ananyahjha93,
carmocca,
lezwon,
nateraw,
rohitgr7,
s-rog and
yukw777
tchaton
approved these changes
Jan 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #5458 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10013 10015 +2
======================================
+ Hits 9334 9338 +4
+ Misses 679 677 -2 |
justusschock
approved these changes
Jan 11, 2021
carmocca
reviewed
Jan 11, 2021
Borda
commented
Jan 11, 2021
| @@ -1,12 +0,0 @@ | |||
| import os | |||
Collaborator
Author
There was a problem hiding this comment.
not sure why the package was renamed even this script was never called, so rather remove it completely
https://github.com/PyTorchLightning/pytorch-lightning/runs/1678482450?check_suite_focus=true#step:6:1523
SeanNaren
approved these changes
Jan 11, 2021
Contributor
SeanNaren
left a comment
SeanNaren
left a comment
There was a problem hiding this comment.
Not an expert around this but looks alright
ydcjeff
reviewed
Jan 11, 2021
Co-authored-by: Jeff Yang <[email protected]>
ydcjeff
reviewed
Jan 11, 2021
SeanNaren
pushed a commit
that referenced
this pull request
Jan 12, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 12, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 13, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 13, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 19, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
Borda
added a commit
that referenced
this pull request
Jan 23, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
Borda
added a commit
that referenced
this pull request
Jan 25, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
Borda
added a commit
that referenced
this pull request
Jan 26, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
Borda
added a commit
that referenced
this pull request
Jan 26, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
Borda
added a commit
that referenced
this pull request
Jan 26, 2021
* update used Twine * . * . * install * install * . * . * . * . * . * . Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 9611a7f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃