Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jan 12, 2021

What does this PR do?

update trigger for recurrent events and add a link about the reported issue

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration productivity labels Jan 12, 2021
@Borda Borda added this to the 1.1.x milestone Jan 12, 2021
@Borda Borda requested a review from tchaton as a code owner January 12, 2021 11:27
@Borda Borda enabled auto-merge (squash) January 12, 2021 11:28
@Borda Borda added the priority: 1 Medium priority task label Jan 12, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 12, 2021
@Borda Borda mentioned this pull request Jan 12, 2021
12 tasks
@Borda Borda self-assigned this Jan 12, 2021
@Borda Borda merged commit c00d570 into master Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #5480 (d99fc86) into master (9611a7f) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5480    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         135     135            
  Lines       10015    9875   -140     
=======================================
- Hits         9338    9185   -153     
- Misses        677     690    +13     

@Borda Borda deleted the ci/recurrent branch January 12, 2021 14:53
SeanNaren pushed a commit that referenced this pull request Jan 12, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
SeanNaren pushed a commit that referenced this pull request Jan 12, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
SeanNaren pushed a commit that referenced this pull request Jan 13, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
SeanNaren pushed a commit that referenced this pull request Jan 13, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
SeanNaren pushed a commit that referenced this pull request Jan 19, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
Borda added a commit that referenced this pull request Jan 23, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
Borda added a commit that referenced this pull request Jan 25, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
Borda added a commit that referenced this pull request Jan 26, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
Borda added a commit that referenced this pull request Jan 26, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
Borda added a commit that referenced this pull request Jan 26, 2021
* ci: update recurent events

* split events

* .

* .

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c00d570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants