Fix vmmap change_prot fragmentation and alignment bugs #513

ChinmayShringi · 2025-11-04T20:00:55Z

Purpose

Fixes vmmap memory protection change logic and alignment calculation bugs that caused 8 unit test failures.

Issues

Fixes #498

Changes

1. Fixed `change_prot` Function

The previous implementation modified entries in-place during iteration while scheduling overlapping intervals for insertion, causing excessive fragmentation.

Root cause:

Modified local variable ent_start but not the actual interval tree entry
Applied protection changes to entire original entries regardless of target range
Created overlapping fragments through insert_overwrite calls

Solution:

Implemented two-phase approach: collect affected entries, then modify
Properly split entries into three parts: before target (original protection), inside target (new protection), after target (original protection)
Added optimization to avoid fragmentation when protection is unchanged
Correctly update page_num and npages fields for each split part

2. Fixed `find_map_space_with_hint` Alignment

The previous implementation calculated aligned_end - rounded_num_pages which did not guarantee start alignment.

Solution:

Leverage that rounded_num_pages is already a multiple of pages_per_map
Since aligned_end_page is also a multiple, their difference is guaranteed to be aligned
Added debug assertions to verify alignment invariants

Testing

All 8 previously failing tests now pass:

test_change_prot_end_of_region
test_change_prot_exact_boundaries
test_change_prot_middle_of_region
test_change_prot_multiple_times
test_change_prot_spanning_multiple_regions
test_change_prot_to_none
test_change_prot_to_same_value
test_find_map_space_with_hint_alignment_in_pages

- Refactor change_prot to use two-phase approach avoiding fragmentation - Add optimization to skip splitting when protection unchanged - Fix find_map_space_with_hint alignment calculation - Addresses all 8 failing unit tests from issue #498

github-actions · 2025-11-04T20:16:15Z

End-to-End Test Report

Test Preview

Test Report

Deterministic Tests

Summary

Metric	Count
Total Test Cases	67
Number of Successes	67
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chmod.c	Success	None	Mode changed successfully
close.c	Success	None	File opened and closed 2000 times successfully.
doubleclose.c	Success	None
dupwrite.c	Success	None	write succeeded
fchmod.c	Success	None	Mode changed successfully
fcntl.c	Success	None	Original FD: 3 F_DUPFD duplicated FD: 100 F_DUPFD_CLOEXEC duplicated FD: 101 Original FD flags: FD flags = 0x0 F_DUPFD duplicated FD flags: FD flags = 0x0 F_DUPFD_CLOEXEC duplicated FD flags: FD flags = 0x1 After F_SETFD on F_DUPFD duplicated FD: FD flags = 0x1 Test completed successfully.
fdatasync.c	Success	None
filetest.c	Success	None	AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
filetest1000.c	Success	None	AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
fstat.c	Success	None	running fstat("testfiles/fstatfile.txt") size: 19
fsync.c	Success	None
ioctl.c	Success	None	[For 0 = False and = True] [The answers should be F, T, F] (0) Is the socket set for non-blocking I/O?: 0 [Setting socket for non_blocking I/O] (1) Is the socket set for non-blocking I/O?: 2048 [Clearing socket for non-blocking I/O] (2) Is the socket set for non-blocking I/O?: 0
mkdir_rmdir.c	Success	None	Created directory successfully Removed directory successfully
open.c	Success	None	File opened successfully with fd = 3
pread_pwrite.c	Success	None	[file is opened] [succeeded write(1) process] [reading(1) data] from pwrite.txt [Lind is amazing!] ----------------------------------- [succeeded write(2) process] [reading(2) data] from pwrite.txt [NYU is amazing!] [succeeded in close]
printf.c	Success	None	Hello, World!
readbytes.c	Success	None	This is a test of the wonderful fork call in lind.�
readlink.c	Success	None	=== Test Case 1: Valid symbolic link === Symbolic link points to: /src/RawPOSIX/tmp/testfiles/readlinkfile.txt === Test Case 2: Path is not a symbolic link === Expected failure: Invalid argument === Test Case 3: Symbolic link with buffer too small === Symbolic link truncated result: /src/ === Test Case 4: Non-existent path === Expected failure: No such file or directory
rename.c	Success	None	SUCCESS WITH RENAMING
stat.c	Success	None	running stat("testfiles/statfile.txt") size: 18
sync_file_range.c	Success	None	sync_file_range test completed successfully.
truncate.c	Success	None	Test truncate(const char *, off_t) Truncating testfiles/truncatefile.txt from 32 to 155 Success Truncating testfiles/truncatefile.txt from 155 to 32 Success Test ftruncate(int, off_t) Truncating testfiles/truncatefile.txt from 32 to 155 Success Truncating testfiles/truncatefile.txt from 155 to 32 Success
unlinkat.c	Success	None	=== Test Case 1: Remove valid file === Test Case 1: Successfully removed testfiles/unlinkatfile.txt === Test Case 2: Remove non-existent file === Test Case 2: Expected failure: No such file or directory === Test Case 3: Remove file in a subdirectory === Test Case 3: Successfully removed file in subdirectory === Test Case 4: Remove a directory with AT_REMOVEDIR === Test Case 4: Successfully removed directory testfiles/unlinkatsubdir === Test Case 5: Remove a directory without AT_REMOVEDIR === Test Case 5: Expected failure: Is a directory
write.c	Success	None	Hello world from Coulson's WASM
writeloop.c	Success	None	write succeeded
writepartial.c	Success	None	write
Memory Tests
brk.c	Success	None	PASS
malloc.c	Success	None
memcpy.c	Success	None	Hello, World!
mmap.c	Success	None	mmap test: PASS
mmap_file.c	Success	None	Data written to memory-mapped file: Hello, mmap! Data read back from memory-mapped file: Hello, mmap!
mprotect.c	Success	None	Mprotect write test text
sbrk.c	Success	None	Content in allocated memory: Hello, sbrk memory!
shmtest.c	Success	None
Networking Tests
gethostname.c	Success	None	Hostname: buildkitsandbox
makepipe.c	Success	None
pipepong.c	Success	None	Parent sending 1 Child received 1 Child sends 2 Parent received 2 Parent sending 3 Child received 3 Child sends 4 Parent received 4 Parent sending 5 Child received 5 Child sends 6 Parent received 6 Parent sending 7 Child received 7 Child sends 8 Parent received 8 Parent sending 9 Child received 9 Child sends 10 Parent received 10 Parent sending 11 Child received 11 Child sends 12 Parent received 12 Parent sending 13 Child received 13 Child sends 14 Parent received 14 Parent sending 15 Child received 15 Child sends 16 Parent received 16 Parent sending 17 Child received 17 Child sends 18 Parent received 18 Parent sending 19 Child received 19 Child sends 20 Parent received 20 Parent sending 21 Child received 21 Child sends 22 Parent received 22 Parent sending 23 Child received 23 Child sends 24 Parent received 24 Parent sending 25 Child received 25 Child sends 26 Parent received 26 Parent sending 27 Child received 27 Child sends 28 Parent received 28 Parent sending 29 Child received 29 Child sends 30 Parent received 30 Parent sending 31 Child received 31 Child sends 32 Parent received 32 Parent sending 33 Child received 33 Child sends 34 Parent received 34 Parent sending 35 Child received 35 Child sends 36 Parent received 36 Parent sending 37 Child received 37 Child sends 38 Parent received 38 Parent sending 39 Child received 39 Child sends 40 Parent received 40 Parent sending 41 Child received 41 Child sends 42 Parent received 42 Parent sending 43 Child received 43 Child sends 44 Parent received 44 Parent sending 45 Child received 45 Child sends 46 Parent received 46 Parent sending 47 Child received 47 Child sends 48 Parent received 48 Parent sending 49 Child received 49 Child sends 50 Parent received 50 Parent sending 51 Child received 51 Child sends 52 Parent received 52 Parent sending 53 Child received 53 Child sends 54 Parent received 54 Parent sending 55 Child received 55 Child sends 56 Parent received 56 Parent sending 57 Child received 57 Child sends 58 Parent received 58 Parent sending 59 Child received 59 Child sends 60 Parent received 60 Parent sending 61 Child received 61 Child sends 62 Parent received 62 Parent sending 63 Child received 63 Child sends 64 Parent received 64 Parent sending 65 Child received 65 Child sends 66 Parent received 66 Parent sending 67 Child received 67 Child sends 68 Parent received 68 Parent sending 69 Child received 69 Child sends 70 Parent received 70 Parent sending 71 Child received 71 Child sends 72 Parent received 72 Parent sending 73 Child received 73 Child sends 74 Parent received 74 Parent sending 75 Child received 75 Child sends 76 Parent received 76 Parent sending 77 Child received 77 Child sends 78 Parent received 78 Parent sending 79 Child received 79 Child sends 80 Parent received 80 Parent sending 81 Child received 81 Child sends 82 Parent received 82 Parent sending 83 Child received 83 Child sends 84 Parent received 84 Parent sending 85 Child received 85 Child sends 86 Parent received 86 Parent sending 87 Child received 87 Child sends 88 Parent received 88 Parent sending 89 Child received 89 Child sends 90 Parent received 90 Parent sending 91 Child received 91 Child sends 92 Parent received 92 Parent sending 93 Child received 93 Child sends 94 Parent received 94 Parent sending 95 Child received 95 Child sends 96 Parent received 96 Parent sending 97 Child received 97 Child sends 98 Parent received 98 Parent sending 99 Child received 99 Child sends 100 Parent received 100 Pipe Pong complete. Final value: 100
poll.c	Success	None	stdout is ready for writing.
recvfrom-sendto.c	Success	None	Client sent: Hello recvfrom!
simple_epoll.c	Success	None	waiting for epoll event... got data: hello epoll!
socket.c	Success	None	Socket opened succesfully.
socket_cloexec.c	Success	None	SOCK_CLOEXEC is set.
socketpair.c	Success	None	-->In Xanadu, did Kublai Khan . . . -->A stately pleasure dome decree . . .
tcp_connect_single.c	Success	None
Process Tests
chain_thread.c	Success	None	Outer thread running... Inner thread running... Inner thread done. Outer thread done. Main thread done.
exit.c	Success	None	Exiting...
forkexecv-arg.c	Success	None	Received argument: hello-arg
forkexecv.c	Success	None	wark
function-ptr.c	Success	None	Hello, World!
getppid.c	Success	None	getppid() succeeded
hello-arg.c	Success	None	Received argument: hello-arg
hello.c	Success	None	wark
longjmp.c	Success	None	In main: Calling first_function... In first_function: Calling second_function... In second_function: Performing a long jump... Back in main: long jump returned with value = 42
noforkfiles.c	Success	None
sem_forks.c	Success	None
setsid.c	Success	None	setsid() succeeded.
thread-test.c	Success	None	Hello from the thread! Thread has finished execution
thread.c	Success	None	Hello from thread
wait.c	Success	None	Parent detected child finished. Child exited with status 0
waitpid_wnohang.c	Success	None
Signal Tests
alarm.c	Success	None	Setting an alarm to trigger in 1 seconds... Alarm triggered! Signal received: 14 Alarm triggered! Signal received: 14 Alarm triggered! Signal received: 14
setitimer.c	Success	None	Timer started! SIGALRM will fire every 3 seconds. Timer expired! Signal received: 14 Timer expired! Signal received: 14 Timer expired! Signal received: 14
sigalrm.c	Success	None	SIGALRM signals blocked Alarm Handled. Exiting
sigchld.c	Success	None	Signal Child Test!
signal-fork.c	Success	None	Successfully changed the signal handler for Signal 12 Killing Child Signal Handler Test! Exiting Child
signal-simple.c	Success	None	Successfully changed the signal handler for Signal 12 Signal Handler Test!
sigprocmask.c	Success	None	blocking SIGUSR2 Sending SIGUSR2 Sleeping 1 second unblocking signal Signal Handler! Exiting program

Non Deterministic Tests

Summary

Metric	Count
Total Test Cases	41
Number of Successes	41
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chdir_getcwd.c	Success	None	getcwd() error: Success getcwd() error: Success
clock_gettime_highlevel.c	Success	None	Running 1,000,000 iterations... Start time: 6585 clock ticks End time: 8911 clock ticks Elapsed CPU time: 0.002326 seconds
clock_gettime_simple.c	Success	None	Current time: 1762287009 seconds and 789068413 nanoseconds
dup.c	Success	None	duped fd: 3 attempting to write to dup() fd write to dup() fd succeeded write to old fd succeeded
fchdir.c	Success	None	getcwd() error: Success
fstatfs.c	Success	None	Filesystem type: 794c7630
getcwd.c	Success	None	getcwd() error: Success
read.c	Success	None	open(): No such file or directory
statfs.c	Success	None	Filesystem type: 794c7630
Memory Tests
malloc_large.c	Success	None	0xefffe010: 42
mmap_complicated.c	Success	None	Parent: Waiting for child to write. Child: Writing to shared memory. Parent: Reading from shared memory: 'Hello from the child process!' Child: Reading from shared memory: 'Hello from the parent process!' Child: Exiting. Parent: Reading modified shared memory: 'Hello from the parent process!' Parent: Exiting.
mmap_shared.c	Success	None	parent value: 1234, 4321 parent value after fork: 1234, 4321 child value after fork: 1234, 4321 parent value after modification: 2333, 3332 child value after modification: 2333, 4321
segfault.c	Success	None	pipe() ret: [3, 4] read() ret: 3 hi
shm.c	Success	None	Shared memory segment created with id: 1 Parent attached to shared memory at 0xffffe000 Parent wrote: 'Hello from parent' Child attached to shared memory at 0xffffe000 Child reads: 'Hello from parent' Child detached from shared memory Parent reads: 'Hello from child' Parent detached from shared memory Shared memory segment removed
vtable.c	Success	None	Shape 0 area: 12 Shape 1 area: 19.635
Networking Tests
dnstest.c	Success	None	is sockfd valid? yes 37 is the length sent 53 is the length recieved the dns lookup yields the ip address: 35.172.89.115
getifaddrs.c	Success	None	getifaddrs: Bad address
pipe.c	Success	None	pipe() ret: [3, 4] write() ret: 3 read() ret: 3 hi
pipe2.c	Success	None	pipe2() ret: [3, 4] write() ret: 3 read() ret: 3 hi
pipeinput.c	Success	None	about to write to pipe in parent I'm parent with pid: 2 Hey Nick!
pipeinput2.c	Success	None	about to write to pipe in parent I'm parent with pid: 2 Hey Nick!
pipeonestring.c	Success	None	about to write to pipe in parent I'm child with pid: 0 I'm parent with pid: 2 Hey Nick! ��
pipewrite.c	Success	None	Made pipe with write end 3 and read end 4 wrote 16 write 16 wrote 16 wrote three messages to the pipe msg 0, length 16: hello, world #1 msg 1, length 16: hello, world #2 msg 2, length 16: hello, world #3
shutdown_fork.c	Success	None	5�4d-05
simple-select.c	Success	None	[child] waiting for data... [parent] writing message [child] got data: hello select! [child] waiting for data... [child] pipe closed
socketepoll.c	Success	None	SERVER: New socket bound and listen SERVER: NEW CONNECTION CLIENT: Hello message sent Hello from client Message Received CLIENT: sending followup Did you get my message? CLIENT: Closed connection Closed connection on descriptor 6 read error: Connection reset by peer
Process Tests
fork2malloc.c	Success	None	first malloc Address of mptr1 0x30010 Contents of mptr1 deadbeef pre-fork in child Address of mptr1 0x30fc0 done
fork_simple.c	Success	None	Parent pid = 1 Child pid = 2
forkandopen.c	Success	None	Parent: Testing open in parent: pid 2! Child: Testing open in child: pid 0! Parent: Pid 2 opened fd 3 Child: Pid 0 opened fd 3
forkfiles.c	Success	None	This is a test of the wonderful fork call in lind. read 51 chars
forkmalloc.c	Success	None	in child pointer address is 0x30010 done
forknodup.c	Success	None	I'm the PARENT I'm the child all done all done
getpid.c	Success	None	printing pidSuccess
Signal Tests
signal.c	Success	None	main starts! parent in loop, pid=1 child ready to kill child done kill Caught signal 10 parent in loop, pid=1 Terminated
signal_SIGCHLD.c	Success	None	main starts! parent in loop, pid=1 child ready to kill child done kill Caught signal 17 Caught signal 10
signal_fork.c	Success	None	main starts! parent in loop, pid=1 child ready to kill child done kill Caught signal 2 after fork inside signal handler, pid=3 after fork inside signal handler, pid=1 parent in loop, pid=3 parent in loop, pid=1 parent in loop, pid=1 parent in loop, pid=3 parent in loop, pid=1 parent in loop, pid=3 parent in loop, pid=1 parent in loop, pid=3
signal_int_thread.c	Success	None	main starts! Hello from thread thread sleep thread sleep child ready to kill child done kill child in loop, pid=2 Terminated Terminated child in loop, pid=2 child in loop, pid=2 child in loop, pid=2 child in loop, pid=2
signal_longjmp.c	Success	None	main starts! parent in loop, pid=1 child ready to kill child done kill Caught signal 10 after fork inside signal handler, pid=3 after fork inside signal handler, pid=1 after child longjmp (should only be printed once by parent) parent in loop, pid=1 back from setjmp: 42! pid=3 parent in loop, pid=1 parent in loop, pid=1 parent in loop, pid=1
signal_nodefer.c	Success	None	main starts! parent in loop, pid=1 child ready to kill child sent SIGUSR1 child ready to send SIGUSR1 again Caught signal 10 child done kill Caught signal 10 start of signal handler end of signal handler start of signal handler end of signal handler parent in loop, pid=1 parent in loop, pid=1 parent in loop, pid=1 parent in loop, pid=1
signal_procmask.c	Success	None	Parent: Blocking SIGINT... Signal 2 is BLOCKED Parent: SIGINT is blocked. Child will send SIGINT soon... Child: Sending SIGINT to parent (PID: 1) Parent: Unblocking SIGINT now. SIGINT received! (Handled in Parent Process) Signal 2 is UNBLOCKED Parent: Waiting for SIGINT...
signal_sa_mask.c	Success	None	main starts! parent in loop, pid=1 child ready to kill child done kill Caught signal 10 signal 10 done Caught signal 12 signal 12 done parent in loop, pid=1 parent in loop, pid=1 parent in loop, pid=1 parent in loop, pid=1

rennergade · 2025-11-04T21:32:51Z

This is great, thank you @ChinmayShringi

Could we possibly add a full system integration test to confirm this as well?

github-actions · 2025-11-15T18:40:04Z

End-to-End Test Report

Test Preview

Test Report

Deterministic Tests

Summary

Metric	Count
Total Test Cases	74
Number of Successes	74
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chmod.c	Success	None	Success
close.c	Success	None	Success
doubleclose.c	Success	None	Success
dupwrite.c	Success	None	Success
fchmod.c	Success	None	Success
fcntl.c	Success	None	Success
fdatasync.c	Success	None	Success
filetest.c	Success	None	Success
filetest1000.c	Success	None	Success
fstat.c	Success	None	Success
fsync.c	Success	None	Success
ioctl.c	Success	None	Success
mkdir_rmdir.c	Success	None	Success
open.c	Success	None	Success
pread_pwrite.c	Success	None	Success
printf.c	Success	None	Success
readbytes.c	Success	None	Success
readlink.c	Success	None	Success
rename.c	Success	None	Success
stat.c	Success	None	Success
sync_file_range.c	Success	None	Success
truncate.c	Success	None	Success
unlinkat.c	Success	None	Success
write.c	Success	None	Success
writeloop.c	Success	None	Success
writepartial.c	Success	None	Success
Memory Tests
brk.c	Success	None	Success
malloc.c	Success	None	Success
memcpy.c	Success	None	Success
mmap.c	Success	None	Success
mmap_aligned.c	Success	None	Success
mmap_file.c	Success	None	Success
mprotect.c	Success	None	Success
mprotect_boundary.c	Success	None	Success
mprotect_end_region.c	Success	None	Success
mprotect_middle_region.c	Success	None	Success
mprotect_multiple_times.c	Success	None	Success
mprotect_same_value.c	Success	None	Success
mprotect_spanning_regions.c	Success	None	Success
sbrk.c	Success	None	Success
shmtest.c	Success	None	Success
Networking Tests
gethostname.c	Success	None	Success
makepipe.c	Success	None	Success
pipepong.c	Success	None	Success
poll.c	Success	None	Success
recvfrom-sendto.c	Success	None	Success
simple_epoll.c	Success	None	Success
socket.c	Success	None	Success
socket_cloexec.c	Success	None	Success
socketpair.c	Success	None	Success
tcp_connect_single.c	Success	None	Success
Process Tests
chain_thread.c	Success	None	Success
exit.c	Success	None	Success
forkexecv-arg.c	Success	None	Success
forkexecv.c	Success	None	Success
function-ptr.c	Success	None	Success
getppid.c	Success	None	Success
hello-arg.c	Success	None	Success
hello.c	Success	None	Success
longjmp.c	Success	None	Success
noforkfiles.c	Success	None	Success
sem_forks.c	Success	None	Success
setsid.c	Success	None	Success
thread-test.c	Success	None	Success
thread.c	Success	None	Success
wait.c	Success	None	Success
waitpid_wnohang.c	Success	None	Success
Signal Tests
alarm.c	Success	None	Success
setitimer.c	Success	None	Success
sigalrm.c	Success	None	Success
sigchld.c	Success	None	Success
signal-fork.c	Success	None	Success
signal-simple.c	Success	None	Success
sigprocmask.c	Success	None	Success

Non Deterministic Tests

Summary

Metric	Count
Total Test Cases	41
Number of Successes	40
Number of Failures	1
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	1
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chdir_getcwd.c	Success	None	Success
clock_gettime_highlevel.c	Success	None	Success
clock_gettime_simple.c	Success	None	Success
dup.c	Success	None	Success
fchdir.c	Success	None	Success
fstatfs.c	Success	None	Success
getcwd.c	Success	None	Success
read.c	Success	None	Success
statfs.c	Success	None	Success
Memory Tests
malloc_large.c	Success	None	Success
mmap_complicated.c	Success	None	Success
mmap_shared.c	Success	None	Success
segfault.c	Success	None	Success
shm.c	Success	None	Success
vtable.c	Success	None	Success
Networking Tests
dnstest.c	Success	None	Success
getifaddrs.c	Success	None	Success
pipe.c	Success	None	Success
pipe2.c	Success	None	Success
pipeinput.c	Success	None	Success
pipeinput2.c	Success	None	Success
pipeonestring.c	Success	None	Success
pipewrite.c	Success	None	Success
shutdown_fork.c	Success	None	Success
simple-select.c	Success	None	Success
socketepoll.c	Failure	Lind_wasm_Timeout	Timed Out (timeout: 10s)
Process Tests
fork2malloc.c	Success	None	Success
fork_simple.c	Success	None	Success
forkandopen.c	Success	None	Success
forkfiles.c	Success	None	Success
forkmalloc.c	Success	None	Success
forknodup.c	Success	None	Success
getpid.c	Success	None	Success
Signal Tests
signal.c	Success	None	Success
signal_SIGCHLD.c	Success	None	Success
signal_fork.c	Success	None	Success
signal_int_thread.c	Success	None	Success
signal_longjmp.c	Success	None	Success
signal_nodefer.c	Success	None	Success
signal_procmask.c	Success	None	Success
signal_sa_mask.c	Success	None	Success

Yaxuan-w · 2025-11-15T20:48:53Z

CI test failed. Should we fix this before merge?

rennergade · 2025-11-15T20:51:48Z

CI test failed. Should we fix this before merge?

I'll rerun this but I'm 99% certain that it's unrelated to this PR and due to this: #489

github-actions · 2025-11-15T20:52:41Z

End-to-End Test Report

Test Preview

Test Report

Deterministic Tests

Summary

Metric	Count
Total Test Cases	74
Number of Successes	74
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chmod.c	Success	None	Success
close.c	Success	None	Success
doubleclose.c	Success	None	Success
dupwrite.c	Success	None	Success
fchmod.c	Success	None	Success
fcntl.c	Success	None	Success
fdatasync.c	Success	None	Success
filetest.c	Success	None	Success
filetest1000.c	Success	None	Success
fstat.c	Success	None	Success
fsync.c	Success	None	Success
ioctl.c	Success	None	Success
mkdir_rmdir.c	Success	None	Success
open.c	Success	None	Success
pread_pwrite.c	Success	None	Success
printf.c	Success	None	Success
readbytes.c	Success	None	Success
readlink.c	Success	None	Success
rename.c	Success	None	Success
stat.c	Success	None	Success
sync_file_range.c	Success	None	Success
truncate.c	Success	None	Success
unlinkat.c	Success	None	Success
write.c	Success	None	Success
writeloop.c	Success	None	Success
writepartial.c	Success	None	Success
Memory Tests
brk.c	Success	None	Success
malloc.c	Success	None	Success
memcpy.c	Success	None	Success
mmap.c	Success	None	Success
mmap_aligned.c	Success	None	Success
mmap_file.c	Success	None	Success
mprotect.c	Success	None	Success
mprotect_boundary.c	Success	None	Success
mprotect_end_region.c	Success	None	Success
mprotect_middle_region.c	Success	None	Success
mprotect_multiple_times.c	Success	None	Success
mprotect_same_value.c	Success	None	Success
mprotect_spanning_regions.c	Success	None	Success
sbrk.c	Success	None	Success
shmtest.c	Success	None	Success
Networking Tests
gethostname.c	Success	None	Success
makepipe.c	Success	None	Success
pipepong.c	Success	None	Success
poll.c	Success	None	Success
recvfrom-sendto.c	Success	None	Success
simple_epoll.c	Success	None	Success
socket.c	Success	None	Success
socket_cloexec.c	Success	None	Success
socketpair.c	Success	None	Success
tcp_connect_single.c	Success	None	Success
Process Tests
chain_thread.c	Success	None	Success
exit.c	Success	None	Success
forkexecv-arg.c	Success	None	Success
forkexecv.c	Success	None	Success
function-ptr.c	Success	None	Success
getppid.c	Success	None	Success
hello-arg.c	Success	None	Success
hello.c	Success	None	Success
longjmp.c	Success	None	Success
noforkfiles.c	Success	None	Success
sem_forks.c	Success	None	Success
setsid.c	Success	None	Success
thread-test.c	Success	None	Success
thread.c	Success	None	Success
wait.c	Success	None	Success
waitpid_wnohang.c	Success	None	Success
Signal Tests
alarm.c	Success	None	Success
setitimer.c	Success	None	Success
sigalrm.c	Success	None	Success
sigchld.c	Success	None	Success
signal-fork.c	Success	None	Success
signal-simple.c	Success	None	Success
sigprocmask.c	Success	None	Success

Non Deterministic Tests

Summary

Metric	Count
Total Test Cases	41
Number of Successes	40
Number of Failures	1
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	1
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chdir_getcwd.c	Success	None	Success
clock_gettime_highlevel.c	Success	None	Success
clock_gettime_simple.c	Success	None	Success
dup.c	Success	None	Success
fchdir.c	Success	None	Success
fstatfs.c	Success	None	Success
getcwd.c	Success	None	Success
read.c	Success	None	Success
statfs.c	Success	None	Success
Memory Tests
malloc_large.c	Success	None	Success
mmap_complicated.c	Success	None	Success
mmap_shared.c	Success	None	Success
segfault.c	Success	None	Success
shm.c	Success	None	Success
vtable.c	Success	None	Success
Networking Tests
dnstest.c	Success	None	Success
getifaddrs.c	Success	None	Success
pipe.c	Success	None	Success
pipe2.c	Success	None	Success
pipeinput.c	Success	None	Success
pipeinput2.c	Success	None	Success
pipeonestring.c	Success	None	Success
pipewrite.c	Success	None	Success
shutdown_fork.c	Success	None	Success
simple-select.c	Success	None	Success
socketepoll.c	Failure	Lind_wasm_Timeout	Timed Out (timeout: 10s)
Process Tests
fork2malloc.c	Success	None	Success
fork_simple.c	Success	None	Success
forkandopen.c	Success	None	Success
forkfiles.c	Success	None	Success
forkmalloc.c	Success	None	Success
forknodup.c	Success	None	Success
getpid.c	Success	None	Success
Signal Tests
signal.c	Success	None	Success
signal_SIGCHLD.c	Success	None	Success
signal_fork.c	Success	None	Success
signal_int_thread.c	Success	None	Success
signal_longjmp.c	Success	None	Success
signal_nodefer.c	Success	None	Success
signal_procmask.c	Success	None	Success
signal_sa_mask.c	Success	None	Success

rennergade · 2025-11-16T20:24:51Z

tests/unit-tests/memory_tests/deterministic/mmap_aligned.c

+    size_t large_size = 100 * PAGESIZE;
+    unsigned char *large = mmap(NULL, large_size, PROT_READ | PROT_WRITE,
+                                MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+    if (large == MAP_FAILED) {


think all of these checking statements would be better off as asserts across all these tests

github-actions · 2025-11-19T03:27:57Z

End-to-End Test Report

Test Preview

Test Report

Deterministic Tests

Summary

Metric	Count
Total Test Cases	75
Number of Successes	73
Number of Failures	2
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	1
Number of Timeout During Lind Wasm run	1
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chmod.c	Success	None	Success
close.c	Success	None	Success
doubleclose.c	Success	None	Success
dupwrite.c	Success	None	Success
fchmod.c	Success	None	Success
fcntl.c	Success	None	Success
fdatasync.c	Success	None	Success
filetest.c	Success	None	Success
filetest1000.c	Success	None	Success
fstat.c	Success	None	Success
fsync.c	Success	None	Success
ioctl.c	Success	None	Success
mkdir_rmdir.c	Success	None	Success
open.c	Success	None	Success
pread_pwrite.c	Success	None	Success
printf.c	Success	None	Success
readbytes.c	Success	None	Success
readlink.c	Success	None	Success
rename.c	Success	None	Success
stat.c	Success	None	Success
sync_file_range.c	Success	None	Success
truncate.c	Success	None	Success
unlinkat.c	Success	None	Success
write.c	Success	None	Success
writeloop.c	Success	None	Success
writepartial.c	Success	None	Success
Memory Tests
brk.c	Success	None	Success
malloc.c	Success	None	Success
memcpy.c	Success	None	Success
mmap.c	Success	None	Success
mmap_aligned.c	Failure	Lind_wasm_Segmentation_Fault	/tmp/wasmtest_artifacts_3uufly00/memory_tests/deterministic/mmap_aligned.c:37: int main(void): Assertion `p == (void *)aligned_addr && "MAP_FIXED didn't honor requested address"' failed. Error: failed to run main module `/tmp/wasmtest_artifacts_3uufly00/memory_tests/deterministic/mmap_aligned.cwasm` Caused by: 0: failed to invoke command default 1: error while executing at wasm backtrace: 0: 0x38565 - mmap_aligned.wasm!abort 1: 0x1daa - mmap_aligned.wasm!__assert_fail_base 2: 0x1f7f - mmap_aligned.wasm!__assert_fail 3: 0x1207 - mmap_aligned.wasm!__original_main 4: 0xd8e - mmap_aligned.wasm!_start 5: 0x9ba4b - mmap_aligned.wasm!_start.command_export note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information 2: wasm trap: wasm `unreachable` instruction executed
mmap_file.c	Success	None	Success
mprotect.c	Success	None	Success
mprotect_boundary.c	Success	None	Success
mprotect_end_region.c	Success	None	Success
mprotect_middle_region.c	Success	None	Success
mprotect_multiple_times.c	Success	None	Success
mprotect_same_value.c	Success	None	Success
mprotect_spanning_regions.c	Success	None	Success
sbrk.c	Success	None	Success
shmtest.c	Success	None	Success
Networking Tests
gethostname.c	Success	None	Success
makepipe.c	Success	None	Success
pipepong.c	Success	None	Success
poll.c	Success	None	Success
recvfrom-sendto.c	Success	None	Success
simple_epoll.c	Success	None	Success
socket.c	Success	None	Success
socket_cloexec.c	Success	None	Success
socketpair.c	Success	None	Success
tcp_connect_single.c	Success	None	Success
Process Tests
chain_thread.c	Success	None	Success
exit.c	Success	None	Success
forkexecv-arg.c	Success	None	Success
forkexecv.c	Success	None	Success
function-ptr.c	Success	None	Success
getppid.c	Success	None	Success
hello-arg.c	Success	None	Success
hello.c	Success	None	Success
longjmp.c	Success	None	Success
mutex.c	Success	None	Success
noforkfiles.c	Success	None	Success
sem_forks.c	Failure	Lind_wasm_Timeout	Timed Out (timeout: 10s)
setsid.c	Success	None	Success
thread-test.c	Success	None	Success
thread.c	Success	None	Success
wait.c	Success	None	Success
waitpid_wnohang.c	Success	None	Success
Signal Tests
alarm.c	Success	None	Success
setitimer.c	Success	None	Success
sigalrm.c	Success	None	Success
sigchld.c	Success	None	Success
signal-fork.c	Success	None	Success
signal-simple.c	Success	None	Success
sigprocmask.c	Success	None	Success

Non Deterministic Tests

Summary

Metric	Count
Total Test Cases	41
Number of Successes	41
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chdir_getcwd.c	Success	None	Success
clock_gettime_highlevel.c	Success	None	Success
clock_gettime_simple.c	Success	None	Success
dup.c	Success	None	Success
fchdir.c	Success	None	Success
fstatfs.c	Success	None	Success
getcwd.c	Success	None	Success
read.c	Success	None	Success
statfs.c	Success	None	Success
Memory Tests
malloc_large.c	Success	None	Success
mmap_complicated.c	Success	None	Success
mmap_shared.c	Success	None	Success
segfault.c	Success	None	Success
shm.c	Success	None	Success
vtable.c	Success	None	Success
Networking Tests
dnstest.c	Success	None	Success
getifaddrs.c	Success	None	Success
pipe.c	Success	None	Success
pipe2.c	Success	None	Success
pipeinput.c	Success	None	Success
pipeinput2.c	Success	None	Success
pipeonestring.c	Success	None	Success
pipewrite.c	Success	None	Success
shutdown_fork.c	Success	None	Success
simple-select.c	Success	None	Success
socketepoll.c	Success	None	Success
Process Tests
fork2malloc.c	Success	None	Success
fork_simple.c	Success	None	Success
forkandopen.c	Success	None	Success
forkfiles.c	Success	None	Success
forkmalloc.c	Success	None	Success
forknodup.c	Success	None	Success
getpid.c	Success	None	Success
Signal Tests
signal.c	Success	None	Success
signal_SIGCHLD.c	Success	None	Success
signal_fork.c	Success	None	Success
signal_int_thread.c	Success	None	Success
signal_longjmp.c	Success	None	Success
signal_nodefer.c	Success	None	Success
signal_procmask.c	Success	None	Success
signal_sa_mask.c	Success	None	Success

github-actions · 2025-11-19T05:27:03Z

End-to-End Test Report

Test Preview

Test Report

Deterministic Tests

Summary

Metric	Count
Total Test Cases	75
Number of Successes	75
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chmod.c	Success	None	Success
close.c	Success	None	Success
doubleclose.c	Success	None	Success
dupwrite.c	Success	None	Success
fchmod.c	Success	None	Success
fcntl.c	Success	None	Success
fdatasync.c	Success	None	Success
filetest.c	Success	None	Success
filetest1000.c	Success	None	Success
fstat.c	Success	None	Success
fsync.c	Success	None	Success
ioctl.c	Success	None	Success
mkdir_rmdir.c	Success	None	Success
open.c	Success	None	Success
pread_pwrite.c	Success	None	Success
printf.c	Success	None	Success
readbytes.c	Success	None	Success
readlink.c	Success	None	Success
rename.c	Success	None	Success
stat.c	Success	None	Success
sync_file_range.c	Success	None	Success
truncate.c	Success	None	Success
unlinkat.c	Success	None	Success
write.c	Success	None	Success
writeloop.c	Success	None	Success
writepartial.c	Success	None	Success
Memory Tests
brk.c	Success	None	Success
malloc.c	Success	None	Success
memcpy.c	Success	None	Success
mmap.c	Success	None	Success
mmap_aligned.c	Success	None	Success
mmap_file.c	Success	None	Success
mprotect.c	Success	None	Success
mprotect_boundary.c	Success	None	Success
mprotect_end_region.c	Success	None	Success
mprotect_middle_region.c	Success	None	Success
mprotect_multiple_times.c	Success	None	Success
mprotect_same_value.c	Success	None	Success
mprotect_spanning_regions.c	Success	None	Success
sbrk.c	Success	None	Success
shmtest.c	Success	None	Success
Networking Tests
gethostname.c	Success	None	Success
makepipe.c	Success	None	Success
pipepong.c	Success	None	Success
poll.c	Success	None	Success
recvfrom-sendto.c	Success	None	Success
simple_epoll.c	Success	None	Success
socket.c	Success	None	Success
socket_cloexec.c	Success	None	Success
socketpair.c	Success	None	Success
tcp_connect_single.c	Success	None	Success
Process Tests
chain_thread.c	Success	None	Success
exit.c	Success	None	Success
forkexecv-arg.c	Success	None	Success
forkexecv.c	Success	None	Success
function-ptr.c	Success	None	Success
getppid.c	Success	None	Success
hello-arg.c	Success	None	Success
hello.c	Success	None	Success
longjmp.c	Success	None	Success
mutex.c	Success	None	Success
noforkfiles.c	Success	None	Success
sem_forks.c	Success	None	Success
setsid.c	Success	None	Success
thread-test.c	Success	None	Success
thread.c	Success	None	Success
wait.c	Success	None	Success
waitpid_wnohang.c	Success	None	Success
Signal Tests
alarm.c	Success	None	Success
setitimer.c	Success	None	Success
sigalrm.c	Success	None	Success
sigchld.c	Success	None	Success
signal-fork.c	Success	None	Success
signal-simple.c	Success	None	Success
sigprocmask.c	Success	None	Success

Non Deterministic Tests

Summary

Metric	Count
Total Test Cases	41
Number of Successes	41
Number of Failures	0
Number of Compilation Failure Native	0
Number of Runtime Failure Native	0
Number of Segmentation Fault Native	0
Number of Timeout During Native	0
Number of Lind Wasm Compile Failure	0
Number of Lind Wasm Runtime Failure	0
Number of Lind Wasm Segmentation Failure	0
Number of Timeout During Lind Wasm run	0
Number of Unknown Failure	0
Number of C Compiler and Wasm Output mismatch	0

Test Results by Category

Test Case	Status	Error Type	Output
File Tests
chdir_getcwd.c	Success	None	Success
clock_gettime_highlevel.c	Success	None	Success
clock_gettime_simple.c	Success	None	Success
dup.c	Success	None	Success
fchdir.c	Success	None	Success
fstatfs.c	Success	None	Success
getcwd.c	Success	None	Success
read.c	Success	None	Success
statfs.c	Success	None	Success
Memory Tests
malloc_large.c	Success	None	Success
mmap_complicated.c	Success	None	Success
mmap_shared.c	Success	None	Success
segfault.c	Success	None	Success
shm.c	Success	None	Success
vtable.c	Success	None	Success
Networking Tests
dnstest.c	Success	None	Success
getifaddrs.c	Success	None	Success
pipe.c	Success	None	Success
pipe2.c	Success	None	Success
pipeinput.c	Success	None	Success
pipeinput2.c	Success	None	Success
pipeonestring.c	Success	None	Success
pipewrite.c	Success	None	Success
shutdown_fork.c	Success	None	Success
simple-select.c	Success	None	Success
socketepoll.c	Success	None	Success
Process Tests
fork2malloc.c	Success	None	Success
fork_simple.c	Success	None	Success
forkandopen.c	Success	None	Success
forkfiles.c	Success	None	Success
forkmalloc.c	Success	None	Success
forknodup.c	Success	None	Success
getpid.c	Success	None	Success
Signal Tests
signal.c	Success	None	Success
signal_SIGCHLD.c	Success	None	Success
signal_fork.c	Success	None	Success
signal_int_thread.c	Success	None	Success
signal_longjmp.c	Success	None	Success
signal_nodefer.c	Success	None	Success
signal_procmask.c	Success	None	Success
signal_sa_mask.c	Success	None	Success

rennergade

this looks great to me now. approved.

ChinmayShringi linked an issue Nov 4, 2025 that may be closed by this pull request

vmmap: Fix vmmap according to failing unit tests #498

Closed

test: c files

3638af7

ChinmayShringi requested review from Yaxuan-w, qianxichen233 and rennergade November 15, 2025 18:41

rennergade reviewed Nov 16, 2025

View reviewed changes

fix: update PR comment

7b4a12a

test run

51590d9

rennergade approved these changes Nov 19, 2025

View reviewed changes

Yaxuan-w approved these changes Nov 19, 2025

View reviewed changes

rennergade merged commit c046cbe into main Nov 20, 2025
2 checks passed

Fix vmmap change_prot fragmentation and alignment bugs #513

Fix vmmap change_prot fragmentation and alignment bugs #513

Uh oh!

Conversation

ChinmayShringi commented Nov 4, 2025

Purpose

Issues

Changes

1. Fixed change_prot Function

2. Fixed find_map_space_with_hint Alignment

Testing

Uh oh!

github-actions bot commented Nov 4, 2025

End-to-End Test Report

Summary

Test Results by Category

Summary

Test Results by Category

Uh oh!

rennergade commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

End-to-End Test Report

Summary

Test Results by Category

Summary

Test Results by Category

Uh oh!

Yaxuan-w commented Nov 15, 2025

Uh oh!

rennergade commented Nov 15, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

End-to-End Test Report

Summary

Test Results by Category

Summary

Test Results by Category

Uh oh!

rennergade Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 19, 2025

End-to-End Test Report

Summary

Test Results by Category

Summary

Test Results by Category

Uh oh!

github-actions bot commented Nov 19, 2025

End-to-End Test Report

Summary

Test Results by Category

Summary

Test Results by Category

Uh oh!

rennergade left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

1. Fixed `change_prot` Function

2. Fixed `find_map_space_with_hint` Alignment