feat: add aave dex #276
Open
feat: add aave dex #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sakulstra is attempting to deploy a commit to the llamaswap Team on Vercel. A member of the Team first needs to authorize it. |
sakulstra
commented
Jun 12, 2024
sakulstra
commented
Jun 14, 2024
| } | ||
| }); | ||
|
|
||
| if (!spender) return { isApproved: true, allowance: ethers.constants.MaxUint256 }; |
Author
There was a problem hiding this comment.
about this i'm not 100% sure, for aave withdrawals no approval is needed so i patched this here to not ask for an approval if spender is not set and then here: https://github.com/LlamaSwap/interface/pull/276/files#diff-d89e52e25c562008423ec8d1f219bbdd0d0be839bc31c4f4a737836b52ed12d6R600 i set it to undefined
Author
|
@0xngmi i think this should be ready for review now. Even the pricing finally works 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing: