Upload carbs-on-board to Nightscout #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I see cob uploading to NS, and I see it showing in urchin! Very nice! It's not showing in the COB plugin in NS, but I believe that is just that NS needs to be updated to look there for Loop cob. |
Collaborator
|
Just waiting to see it update. I reviewed the code and couldn't see anything to improve upon. Will approve once I see the update. |
Collaborator
|
I do see some occasional issue in NS about 'cob' being undefined, but that's probably more NS issues to work through. |
Contributor
Author
|
Awesome! Thanks for reviewing and helping test! |
ps2
added a commit
that referenced
this pull request
Sep 14, 2020
* Update to pumpmanager protocol changes * Present uncertainty alert, and recovery view from pump manager * Fix alert presentation on app restart * Fix tests * Re-present alert if user dismisses recovery ui * Refactor out view and alert logic for uncertain delivery * Add test for PumpManagerError.uncertainDelivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mddub/urchin-cgm#50.
I would appreciate it if someone else (@ps2?) could test this before I merge. You should see something like this in
/api/v1/devicestatus.json?find[loop][$exists]=1: