Skip to content

Conversation

@dnzxy
Copy link
Contributor

@dnzxy dnzxy commented May 1, 2024

Contents

Why this PR?
Please see LoopKit/LoopWorkspace#126

Tests
Tested by running all actions (in conjunction with previously having built another app that writes to the same Match-Secrets repository).

* Bump fastlane to 2.220.0
* Bump action container OS from macOS-12 and 13 to macOS-14
* Buml Xcode selection to latest stable 15.3 (15.4 still in beta)
@marionbarker
Copy link
Contributor

I tested this modification as well. It works as expected and conforms with the updates we had to add to keep Loop main and dev building without Browser Build errors.

@marionbarker
Copy link
Contributor

One comment regarding code inspection.

When I create the PR to LoopWorkspace, I choose to delete the commented out lines in add_identifiers and create_certificate regarding Xcode version because they are not used; e.g. lines 17, 18 and 19 in those 2 yml files.

The reference to Xcode version is already removed from validate_secrets.

@dnzxy
Copy link
Contributor Author

dnzxy commented May 1, 2024

When I create the PR to LoopWorkspace, I choose to delete the commented out lines in add_identifiers and create_certificate regarding Xcode version because they are not used; e.g. lines 17, 18 and 19 in those 2 yml files.

When you do not select a specific Xcode version via sudo xcode-select, Xcode will use the default version that comes with the GitHub action runner image. For macos-14 runners, this is 15.0.1(see here).

I chose to go with the highest available and stable Xcode version for the build action, but stick with using the default version for the other 3 actions. As you can see from my changes, I actually updated the commented out version to 15.3 as well. We can remove the commented out lines, or we can leave them in there. I'm fine with either :)

@gestrich
Copy link
Collaborator

gestrich commented May 1, 2024

Just give me a holler when ready to merge.

@dnzxy
Copy link
Contributor Author

dnzxy commented May 2, 2024

It’s ready to merge. The commented in/out code is up to you. If you are okay with leaving it in the, you can merge. If you prefer to have it removed, I can quickly remove it, and it can be merged 😊

@gestrich gestrich merged commit b5794f5 into LoopKit:dev May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants