Skip to content

Conversation

NeOzay
Copy link
Contributor

@NeOzay NeOzay commented Jul 8, 2024

fix related to #2746

@tomlau10
Copy link
Contributor

tomlau10 commented Jul 9, 2024

Glad that you finally find a proper way to fix it 😄


And as @C3pa mentioned here, I tested your fix on a few similar issues and all of them are cleared now! One stone three birds! 🎉

In your PR description, instead of fix related to #2746, I think you should write it as:

fixes #2746, fixes #2341, fixes #2528, fixes #2303

Only then can properly link the pull request to those issues, and leverage the github's close issue on PR merge function. It requires the keywords (in your case is the word fix) to be immediately before the issue number.

@carsakiller
Copy link
Collaborator

@tomlau10 Thanks for mentioning all the fixed issues! Helps a bunch with organization! I linked them to this PR 🙂.

@NeOzay NeOzay deleted the branch LuaLS:master July 13, 2024 14:35
@NeOzay NeOzay closed this Jul 13, 2024
@NeOzay NeOzay deleted the master branch July 13, 2024 14:35
@NeOzay NeOzay restored the master branch July 13, 2024 14:45
@NeOzay NeOzay reopened this Jul 13, 2024
@sumneko
Copy link
Collaborator

sumneko commented Jul 15, 2024

Thank you!

@sumneko sumneko merged commit 33ba775 into LuaLS:master Jul 15, 2024
@NeOzay NeOzay deleted the master branch July 15, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants