Skip to content

Conversation

@MCLifeLeader
Copy link
Owner

Introduce configuration for the Ollama service and enhance the Docker setup by adding SQL Server and Cosmos DB services. Update scripts to reflect changes in service names and ports.

Copilot AI review requested due to automatic review settings July 2, 2025 00:27
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

👋 Thanks for contributing @MCLifeLeader! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduce Ollama service configuration and streamline Docker setup by centralizing common services and updating scripts to reflect service changes

  • Comment out project-specific compose commands in setup/teardown scripts
  • Consolidate SQL Server and Cosmos DB into docker-compose-common.yml
  • Add Ollama environment variables and stub project-specific compose file

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docker_setup.ps1 Comment out project-specific docker-compose up command
docker_down.ps1 Comment out project-specific docker-compose down command
containers/docker-compose.yml Replace service definitions with stub comment
containers/docker-compose-common.yml Add mssql, cosmosdb services and seq-data volume
containers/.env Add OLLAMA_API_KEY and OLLAMA_MODEL variables
Comments suppressed due to low confidence (5)

docker_setup.ps1:8

  • [nitpick] The placeholder project name ('project') in the commented docker-compose command is ambiguous; consider replacing it with the actual service name (e.g., 'dotnet_example') or documenting the intended value.
    #docker-compose -f "./containers/docker-compose.yml" -p project up -d

docker_down.ps1:8

  • [nitpick] The commented teardown command still uses the placeholder 'project'; update it to match your real compose project name or add a comment explaining the placeholder.
    #docker-compose -f "./containers/docker-compose.yml" -p project down

containers/docker-compose.yml:1

  • This compose file no longer defines any services, which will cause docker-compose commands against it to fail. Either restore the required service definitions or remove the file and its references.
# if needed add project specific resources and enable the line in docker_setup.ps1 and docker_down.ps1

containers/docker-compose-common.yml:132

  • The volumes section and its entries should be correctly indented under the root, matching the services and networks sections. Verify spacing to avoid YAML parsing errors.
  seq-data:

containers/.env:17

  • You've added Ollama environment variables, but no service in the compose files references them. Consider adding an Ollama service definition or removing these unused variables.
OLLAMA_MODEL="llama3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants