Skip to content

Fixes in AzureBackupContainer class definition. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2015
Merged

Fixes in AzureBackupContainer class definition. #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bba690
Fixed a mistake in AzureBackupContainer and added comments for each f…
May 29, 2015
fc61f75
Renamed InstanceId to ContainerId due to conflicts with top level obj…
May 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/ResourceManager/AzureBackup/Commands.AzureBackup/Models/AzureBackupContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,24 +23,51 @@ namespace Microsoft.Azure.Commands.AzureBackup.Cmdlets
/// <summary>
/// Represents Azure Backup Container
/// </summary>
public class AzureBackupContainer : AzureBackupVaultCmdletBase
public class AzureBackupContainer : AzureBackupVaultContextObject
{
/// <summary>
/// Type of the Azure Backup container
/// </summary>
public string ContainerType { get; set; }
Copy link

@piyushka17 piyushka17 May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think a way of letting user know the applicable values here.
Same for Status, HealthStatus.


/// <summary>
/// Friendly name for the Azure Backup container
/// </summary>
public string FriendlyName { get; set; }

/// <summary>
/// Status of health of the Azure Backup container
/// </summary>
public string HealthStatus { get; set; }

public string InstanceId { get; set; }
/// <summary>
/// Id of the Azure Backup Container
/// </summary>
public string ContainerId { get; set; }
Copy link

@piyushka17 piyushka17 May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reasons, why ContainerId, and not InstanceId?

Copy link
Author

@dragonfly91 dragonfly91 May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataSource derives from Container object and it would also have a DataSourceId. This was achieved in BMS by using the Instance Id. But then, we would not be able to store the Container Id (if stored also as InstanceId) for this data source. That's why InstanceId was renamed to a more explicit name - ContainerId.


/// <summary>
/// Name of the Azure Backup container
/// </summary>
public string Name { get; set; }

/// <summary>
/// Friendly name of the parent container
/// </summary>
public string ParentContainerFriendlyName { get; set; }

/// <summary>
/// Name of the parent container
/// </summary>
public string ParentContainerName { get; set; }

/// <summary>
Copy link

@piyushka17 piyushka17 May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to IdMgmt containers?

/// Region where this container is present
/// </summary>
public string Region { get; set; }

/// <summary>
/// Status of registration of the container
/// </summary>
public string RegistrationStatus { get; set; }
}
}