Skip to content

Make sure timeout callbacks always get cleaned up #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Make sure timeout callbacks always get cleaned up #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions asyncpg/protocol/protocol.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,12 +647,12 @@ cdef class BaseProtocol(CoreProtocol):
self.waiter.set_exception(asyncio.TimeoutError())

def _on_waiter_completed(self, fut):
if self.timeout_handle:
self.timeout_handle.cancel()
self.timeout_handle = None
if fut is not self.waiter or self.cancel_waiter is not None:
return
if fut.cancelled():
if self.timeout_handle:
self.timeout_handle.cancel()
self.timeout_handle = None
self._request_cancel()

def _create_future_fallback(self):
Expand Down