Add support for rustfix coverage tracking #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty much a copy of rust-lang/rust#59398 minus the rustc bootstrap things. This will allow rustfix coverage tracking in Clippy and other libraries that emit `MachineApplicable` diagnostics.
|
Let me know if there's something I can help out with. It would be nice to get this merged so we can update rust-lang/rust-clippy#3630. |
|
@laumann would you be up for merging this and releasing a new version? It would be a big help for getting good rustfix test coverage in Clippy edit: woops, Manish was faster, sorry about the ping =) |
|
@phansch Sorry for being so tardy, compiletest has gotten away from me a little bit. |
|
Was a new version released? 0.3.22 looks to be from April, so should this go in 0.3.23? |
|
@laumann No worries at all. I think for this particular PR no new version is required because it's enough to update the rustfix coverage issue using the compiletest-rs master branch temporarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much a copy of rust-lang/rust#59398 and
rust-lang/rust#59677 minus the rustc bootstrap
things.
This will allow rustfix coverage tracking in Clippy and other
libraries that emit
MachineApplicablediagnostics.