Skip to content

Conversation

@NTH19
Copy link
Contributor

@NTH19 NTH19 commented Aug 13, 2022

Description


Hi, guys! I'm a 2022 GSoC Contributor and working on MCS.These days I am trying to optimize the string compared in MCS .Today I find a redundant variable in function my_strnncollsp_simple in ctype-simple.c of MDB

How can this PR be tested?


This change will not change existing test results.
Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch
  • This is a bug fix and the PR is based against the earliest branch in which the bug can be reproduced

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2022

CLA assistant check
All committers have signed the CLA.

@NTH19 NTH19 changed the title Refactor: remove redundant variable in my_strnncollsp_simple function in ctype-simple.c Remove redundant variable in my_strnncollsp_simple function in ctype-simple.c Aug 13, 2022
@NTH19 NTH19 marked this pull request as draft August 16, 2022 10:37
@NTH19 NTH19 marked this pull request as ready for review August 16, 2022 10:37
@NTH19 NTH19 force-pushed the strnncollsp branch 2 times, most recently from 3625c30 to b746548 Compare August 16, 2022 11:10
@LinuxJedi LinuxJedi self-requested a review August 27, 2022 09:18
Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, many thanks!

@LinuxJedi LinuxJedi merged commit 80fbd0e into MariaDB:10.11 Aug 27, 2022
@NTH19 NTH19 deleted the strnncollsp branch August 27, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants