Mdev 5536 Add systemd notify and socket activation capabilities to 10.1 branch #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds optional compile option WITH_SYSTEMD to provide system functions Debian and Ubuntu packages include systemd libraries as dependencies mariadb-service-convert converts the [mysqld_safe] options into an equilivent systemd file which runs mysqld directly. mariadb-socket-convert takes the [mysqld] network and socket options and creates an equalivent mariadb.socket file. System service file can be either Type=notify or a socket activation. Compiling with systemd does not change any previous behaviour expected of mysqld. Development funded by Open Source Developers Club (Australia)
configure.cmake
Outdated
Contributor
There was a problem hiding this comment.
This looks like a way too paranoid check. I'd probably only check for sd-daemon.h. But up to you: I don't see anything wrong about it.
…ermine lib, flags and linkerflags
… mariadb-server-core-10.1. mariadb-systemd-start removed
…d-dev replaces libsystemd-daemon-dev
Member
Author
|
TODO: MDEV-7752 - need to package a mariadb{-galera}@bootstrap - part way there. Might also do a multi instance version. /usr/lib/systemd/systemd-activate can be used to fake the socket activation so I'm part way though packaging that too in the mtr. |
Contributor
There was a problem hiding this comment.
Do we really need this variable? Can we instead do "[ $simulate -eq 0 ] && return" from log_generic()?
Member
Author
|
non-socket activation moved to #100 will get that done first. |
Contributor
|
Daniel, should we close this PR? |
Member
Author
|
yes closing. will do a new one on socket activation alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from all the comments in #26 I've make a 10.1 PR here as, adding dependencies on systemd libs was problematic and socket activation was invasive.
Adds optional compile option WITH_SYSTEMD to provide system functions
Debian and Ubuntu packages include systemd libraries as dependencies
mariadb-service-convert converts the [mysqld_safe] options into an
equilivent systemd file which runs mysqld directly.
mariadb-socket-convert takes the [mysqld] network and socket options
and creates an equalivent mariadb.socket file.
System service file can be either Type=notify or a socket activation.
Compiling with systemd does not change any previous behaviour expected
of mysqld.
Development funded by Open Source Developers Club (Australia)