Update Cursively benchmark code. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
airbreather
commented
Jan 12, 2021
airbreather
commented
- VisitPartialFieldContents is required for correctness
- Use the original byte array, since we have one, instead of forcing a stream around it
- Set iteration time to 1 second, to work around Problems with default UnrollFactor in V0.11.0 dotnet/BenchmarkDotNet#837 while we wait for a version of this package that includes Don't run the benchmark once per iteration if only the first ivocation lasts longer than IterationTime dotnet/BenchmarkDotNet#1573
- VisitPartialFieldContents is required for correctness - Use the original byte array, since we have one, instead of forcing a stream around it - Set iteration time to 1 second, to work around dotnet/BenchmarkDotNet#837 while we wait for a version of this package that includes dotnet/BenchmarkDotNet#1573
MarkPflug
reviewed
Jan 12, 2021
Owner
MarkPflug
left a comment
MarkPflug
left a comment
There was a problem hiding this comment.
Thanks for the updates Joe. I've noted one minor tweak you can make to gain a bit of time.
Whether or not this is the optimal order is almost certain to depend on the data: data sets that would almost never use the pool would likely hurt more by doing it this way, especially if this were a real-world application since this would likely push a line out of the CPU cache for no reason. Then again, a real-world application probably wouldn't use the pool conditionally like this, so there's not much of a reason NOT to either.
Owner
|
Thanks again. I'll get the benchmarks table updated with the results soon. |
Owner
|
I just pushed an update to the reports, reorganizing things a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.