fix outline and breadcumbs for members definition in namespace #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FederAndInk
force-pushed
the
fix/document_symbol
branch
from
e54c4be to
7f438dc
Compare
|
Ok, static member variable aren't collected in Also, another bug I just discovered, I haven't looked up in details:
|
|
static member variable fixed: |
FederAndInk
force-pushed
the
fix/document_symbol
branch
from
6510ae9 to
7f1fc10
Compare
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
7818055 to
99f0b40
Compare
MaskRay
force-pushed
the
master
branch
4 times, most recently
from
a33231a to
cb08df4
Compare
MaskRay
reviewed
Jul 20, 2020
| int16_t short_name_size = 0; | ||
| SymbolKind kind = SymbolKind::Unknown; | ||
| SymbolKind parent_kind = SymbolKind::Unknown; | ||
| SymbolIdx parent = {0, Kind::Invalid}; |
There was a problem hiding this comment.
Will this increase memory usage?
There was a problem hiding this comment.
Yeah, certainly, I haven't done measures. But I am working on another idea which doesn't introduce new things to the index and seems simpler and cleaner.
3 tasks
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996 to
feb153a
Compare
|
Thanks for this patch and the alternative:) Merged the alternative |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have members defined outside the class in a namespace in a separate file, the namespace doesn't have the members as children. The outline and breadcrumbs don't work correctly for them.
Before:
After:
I also refactored a little by removing
void*and replacing it withif constexprsee the first commit if it suits your requirements.There are other bugs with outline that I noticed which I am working on: