Skip to content

Conversation

@corvinsz
Copy link
Member

@corvinsz corvinsz commented Sep 3, 2024

added a ClockButtonVisibility property to the TimePicker to fix #3663

TimePickerShowClickButton

@corvinsz
Copy link
Member Author

corvinsz commented Sep 3, 2024

I know it's hard to define rules as to when and what to test, but are there any guidelines what should be tested and what not?

For this change to the TimePicker I asked myself if that's worth writing a test for. I ended up not writing one because it seems like such a small change.

@Keboo Keboo added enhancement release notes Items are likely to be highlighted in the release notes. labels Sep 5, 2024
@Keboo
Copy link
Member

Keboo commented Sep 5, 2024

I know it's hard to define rules as to when and what to test, but are there any guidelines what should be tested and what not?

For this change to the TimePicker I asked myself if that's worth writing a test for. I ended up not writing one because it seems like such a small change.

In this case I believe your assessment is correct, this probably doesn't warrant any testing. The tests in this project are more integration tests then true unit tests and consequently have a higher cost to run. So it is always good to consider if a change really needs a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement release notes Items are likely to be highlighted in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make TimePicker Icon-Button hidable

2 participants