Make return type consistent in FloatingHintInitialHorizontalOffsetConverter #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verter Previously, line 26 would return the value 0 as an Int32 rather than a double, leading to runtime xaml errors. Now occurrences of 0 are replaced with doubles rather than relying on implicit conversion.
Keboo
approved these changes
Jan 28, 2025
This was referenced Oct 6, 2025
Merged
This was referenced Oct 20, 2025
This was referenced Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, line 26 would return the value
0as anInt32rather than aDouble, leading to runtime xaml errors. Now occurrences of0are replaced with0Drather than relying on implicit conversion.