-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Inherit Windows accent color #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+75
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added "Inherit" enum member to SecondaryColor -added a method to get the Systems accent color
Keboo
reviewed
Mar 11, 2025
make SetField static Co-authored-by: Kevin B <[email protected]>
Keboo
approved these changes
Mar 11, 2025
This was referenced Oct 6, 2025
Merged
This was referenced Oct 20, 2025
This was referenced Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3811
With this PR consumers can use the newly added
Inheritmember for thePrimaryColorandSecondaryColorenum.Just like with
BaseTheme="Inherit"inherit means "take the OS preferences".This is largely based on how it is done in ControlzEx
Notes:
In the case the value could not be read from the registry, or the conversion (registry value --> C# Color) is somehow failing, the code falls back to
SwatchHelper.Lookup.First().Value. One alternative would be to throw an error instead, but I don't think such an "irrelevant" feature should throw an exception.Example:
<materialDesign:BundledTheme BaseTheme="Inherit" ColorAdjustment="{materialDesign:ColorAdjustment}" - PrimaryColor="DeepPurple" + PrimaryColor="Inherit" - SecondaryColor="Lime" /> + SecondaryColor="Inherit" />I also refactored the
BundledThemeclass slightly.