storage: use CapabilityRefs directly
#14781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guswynn
approved these changes
Sep 12, 2022
Contributor
guswynn
left a comment
guswynn
left a comment
There was a problem hiding this comment.
hell ya!
I like this fixes other usages that aren't even using the new async integration
After TimelyDataflow/timely-dataflow#429 holding onto CapabilityRefs across await points is safe Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
use-cap-ref
branch
from
66af74c to
2d7b161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After TimelyDataflow/timely-dataflow#429 holding onto CapabilityRefs across await points is safe